Merge pull request #22 from Fingertips/manfred-21-slash

Allow slash literal in URL when object contains slash

Author: Manfred

spec/cases/http_handler_spec.cr

@@ -10,6 +10,24 @@ describe Greitspitz::HttpHandler do
     end
   end
 
+  it "serves an object with a key that includes a slash" do
+    Spec.with_mocked_object_storage do
+      session = Spec.create_session
+      session.get("/avatars/special/8awboFP4bFrbA8dZ/format:jpeg")
+      session.response_status_code.should eq(200)
+      session.response_content_type.should eq("image/jpeg")
+    end
+  end
+
+  it "serves an object with a key that includes a slash" do
+    Spec.with_mocked_object_storage do
+      session = Spec.create_session
+      session.get("/avatars/special%2F8awboFP4bFrbA8dZ/format:jpeg")
+      session.response_status_code.should eq(200)
+      session.response_content_type.should eq("image/jpeg")
+    end
+  end
+
   it "serves an object from a bucket as a resized AVIF" do
     Spec.with_mocked_object_storage do
       session = Spec.create_session

spec/spec_helper.cr

@@ -45,6 +45,9 @@ module Spec
         WebMock.stub(
           :get, "https://storage.example.com/avatars/w8cfGJVMmjzLdgZf?"
         ).to_return(body_io: file)
+        WebMock.stub(
+          :get, "https://storage.example.com/avatars/special/8awboFP4bFrbA8dZ?"
+        ).to_return(body_io: file)
         WebMock.stub(
           :get, "https://storage.example.com/avatars/1MiD6y6JPh8C4yGT?"
         ).to_return(status: 404, body_io: IO::Memory.new("<?xml><root></root>"))

src/greitspitz/http_handler.cr

@@ -11,8 +11,9 @@ module Greitspitz
     end
 
     def call(context)
-      if context.request.path =~ /^\/([^\/]+)\/([^\/]+)\/([^\/]+)$/
-        handle_request(context, URI.decode($1), URI.decode($2), URI.decode($3))
+      parts = context.request.path.split("/").map { |part| URI.decode(part) }
+      if parts.size > 2
+        handle_request(context, parts[1], parts[2..-2].join("/"), parts[-1])
       else
         call_next(context)
       end