Skip to content

Commit 49fc7b6

Browse files
authored
Merge pull request #710 from MokhaLeee/master
fix banim related wrong macros
2 parents bb1356e + 4d8509d commit 49fc7b6

File tree

5 files changed

+17
-17
lines changed

5 files changed

+17
-17
lines changed

include/ekrbattle.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -598,7 +598,7 @@ extern const u16 gUnknown_080DAEC8[];
598598
extern const u16 gUnknown_080DAED2[];
599599
extern const u16 gUnknown_080DAEDC[];
600600
extern const u16 gUnknown_080DAEE6[];
601-
extern const u8 BattleTypeToAnimModeEndOfDodge[5];
601+
extern const u8 BanimDefaultStandingTypes[5];
602602
extern const u8 BanimTypesPosLeft[5];
603603
extern const u8 BanimTypesPosRight[5];
604604
extern const u16 BanimLeftDefaultPos[5];

src/banim-ekrbattle.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -555,9 +555,9 @@ void ekrBattleInRoundIdle(struct ProcEkrBattle *proc)
555555
struct Anim *anim2 = gAnims[2];
556556

557557
switch (anim1->currentRoundType) {
558-
case BANIM_MODE_CLOSE_DODGE:
559-
case BANIM_MODE_RANGED_DODGE:
560-
case BANIM_MODE_STANDING:
558+
case ANIM_ROUND_TAKING_HIT_CLOSE:
559+
case ANIM_ROUND_STANDING:
560+
case ANIM_ROUND_TAKING_HIT_FAR:
561561
val = 1;
562562
break;
563563

@@ -566,9 +566,9 @@ void ekrBattleInRoundIdle(struct ProcEkrBattle *proc)
566566
} /* switch */
567567

568568
switch (anim2->currentRoundType) {
569-
case BANIM_MODE_CLOSE_DODGE:
570-
case BANIM_MODE_RANGED_DODGE:
571-
case BANIM_MODE_STANDING:
569+
case ANIM_ROUND_TAKING_HIT_CLOSE:
570+
case ANIM_ROUND_STANDING:
571+
case ANIM_ROUND_TAKING_HIT_FAR:
572572
val++;
573573
break;
574574

src/banim-ekrbattleintro.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,7 @@ void UnitKakudaiPrepareAnimScript(struct ProcUnitKakudai * proc)
500500
register int r0 asm("r0");
501501
u8 mode2;
502502

503-
mode2 = BattleTypeToAnimModeEndOfDodge[gEkrDistanceType];
503+
mode2 = BanimDefaultStandingTypes[gEkrDistanceType];
504504
asm("":::"r0", "r1");
505505
cfg = BanimDefaultModeConfig;
506506
r0 = mode2 * 4;
@@ -509,7 +509,7 @@ void UnitKakudaiPrepareAnimScript(struct ProcUnitKakudai * proc)
509509
int mode;
510510
u8 mode2;
511511

512-
mode2 = BattleTypeToAnimModeEndOfDodge[gEkrDistanceType];
512+
mode2 = BanimDefaultStandingTypes[gEkrDistanceType];
513513
front_mode = BanimDefaultModeConfig[mode2 * 4 + 0];
514514
#endif
515515

src/banim-ekrmain.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,12 @@ const u8 BanimDefaultModeConfig[ANIM_ROUND_MAX * 4] = {
6868
BANIM_MODE_MISSED_ATK, 0x64, BANIM_MODE_INVALID, 0x28,
6969
};
7070

71-
const u8 BattleTypeToAnimModeEndOfDodge[5] = {
72-
[EKR_DISTANCE_CLOSE] = BANIM_MODE_CLOSE_DODGE,
73-
[EKR_DISTANCE_FAR] = BANIM_MODE_STANDING,
74-
[EKR_DISTANCE_FARFAR] = BANIM_MODE_STANDING,
75-
[EKR_DISTANCE_MONOCOMBAT] = BANIM_MODE_CLOSE_DODGE,
76-
[EKR_DISTANCE_PROMOTION] = BANIM_MODE_CLOSE_DODGE
71+
const u8 BanimDefaultStandingTypes[5] = {
72+
[EKR_DISTANCE_CLOSE] = ANIM_ROUND_TAKING_HIT_CLOSE,
73+
[EKR_DISTANCE_FAR] = ANIM_ROUND_TAKING_HIT_FAR,
74+
[EKR_DISTANCE_FARFAR] = ANIM_ROUND_TAKING_HIT_FAR,
75+
[EKR_DISTANCE_MONOCOMBAT] = ANIM_ROUND_TAKING_HIT_CLOSE,
76+
[EKR_DISTANCE_PROMOTION] = ANIM_ROUND_TAKING_HIT_CLOSE
7777
};
7878

7979
const u8 BanimTypesPosLeft[5] = {

src/banim-main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ void BattleAIS_ExecCommands(void)
285285
anim1->state3 |= ANIM_BIT3_C01_BLOCKING_IN_BATTLE;
286286
anim2->state3 |= ANIM_BIT3_C01_BLOCKING_IN_BATTLE;
287287

288-
type = BattleTypeToAnimModeEndOfDodge[gEkrDistanceType];
288+
type = BanimDefaultStandingTypes[gEkrDistanceType];
289289
frame_front = BanimDefaultModeConfig[type * 4 + 0];
290290

291291
if (GetAnimPosition(anim) == EKR_POS_L)
@@ -332,7 +332,7 @@ void BattleAIS_ExecCommands(void)
332332

333333
case ANIM_ROUND_TAKING_MISS_CLOSE:
334334
case ANIM_ROUND_TAKING_MISS_FAR:
335-
type = BattleTypeToAnimModeEndOfDodge[gEkrDistanceType];
335+
type = BanimDefaultStandingTypes[gEkrDistanceType];
336336

337337
case ANIM_ROUND_TAKING_HIT_CLOSE:
338338
case ANIM_ROUND_STANDING:

0 commit comments

Comments
 (0)