Incorrect shall have a contained resource if a local reference is provided

[mmsmits]

I have a situation which I don't fully understand with validation.

Example : https://simplifier.net/erezept-workflow/fsh-generated-resources-Parameters-ExampleCloseInputParametersRezeptur/~overview
Base profile: https://simplifier.net/erezept-workflow/gem_erp_pr_par_closeoperation_input

The legacy validator returns this:

Invariant : Instance failed constraint ref-1 "SHALL have a contained resource if a local reference is provided"
Rule: reference.exists() implies (reference.startsWith('#').not() or (reference.substring(1).trace('url') in %rootResource.contained.id.trace('ids')) or (reference='#' and %rootResource!=%resource))
Parameters.parameter[0].part[1].resource[0].ingredient[0].item[0] 

The new validator returns this similar error, but with different explanation:

[ERROR] Instance failed constraint ref-1 "SHALL have a contained resource if a local reference is provided" (at Parameters.parameter[0].part[0].resource[0].performer[0].actor[0], element Parameters(https://gematik.de/fhir/erp/StructureDefinition/GEM_ERP_PR_PAR_CloseOperation_Input).parameter.part.resource->MedicationDispense.performer.actor) 

ref-1 (https://hl7.org/fhir/references.html#Reference) states:

reference.exists() implies (reference.startsWith('#').not() or (reference.substring(1).trace('url') in %rootResource.contained.id.trace('ids')) or (reference='#' and %rootResource!=%resource)) 

Does calling %rootResource cause our Validator to jump to the Parameters Resource, and should it not go towards the Medication Resource?
Is this the part that is causing the issue?

reference.substring(1).trace('url') in %rootResource.contained.id.trace('ids')

What it does is it checks whether the ID of the referenced contained resource exists within the parent resource's contained resource IDs.
The Java Validator does not throw an error here.

Ghost-writer of @MatthijsvdWielen

[MatthijsvdWielen]

Thank you @mmsmits for being my Ghost-writer. I was unable to verify if this was already fixed in v2.5.0 of the new validator.

[mmsmits]

Yes, that's ok, we'll check that. :)

[mmsmits]

This is a duplicate of #FirelyTeam/firely-validator-api#384

[mmsmits]

@Kasdejong, this error was introduced after your work on contained resources I believe.

Short story:
It occurs on reference, that only have an identifier set. The validator sees this as a local reference, and tries to find a contained resource, but the reference.reference is not set, so it returns null (I think). and throws this error. Probably easy to fix.

[mmsmits]

@MatthijsvdWielen
I can't reproduce this error anymore. Has simplifier updated to the latest validator/sdk?

[MatthijsvdWielen]

I have this same issue in Simplifier production now. See my demo project example bundle here: https://simplifier.net/testcontainedresources/fff69194-3394-4e24-9fdb-da7c64a2d9db

When you validate this though the UI it will first pass validation in the "Legacy validator" but the new validator will throw:
Invariant : Instance failed constraint ref-1 "SHALL have a contained resource if a local reference is provided" Bundle.entry[0].resource[0].author[1], element Bundle(https://example.org/fhir/StructureDefinition/MyBundle).entry.resource->Composition(https://example.org/fhir/StructureDefinition/MyComposition).author

Edit; Simplifier is on:
Simplifier / FHIR .NET SDK: 5.10.3
Simplifier / .NET: 8.0.12
Validator version 2.4.0