提高覆盖率

Author: FishGoddess

config.go

@@ -0,0 +1,25 @@
+// Copyright 2025 FishGoddess. All rights reserved.
+// Use of this source code is governed by a MIT style
+// license that can be found in the LICENSE file.
+
+package goes
+
+type config struct {
+	size        int
+	queueSize   int
+	recoverFunc func(r any)
+}
+
+func newDefaultConfig(size int) *config {
+	return &config{
+		size:        size,
+		queueSize:   64,
+		recoverFunc: nil,
+	}
+}
+
+func (c *config) recover(r any) {
+	if c.recoverFunc != nil {
+		c.recoverFunc(r)
+	}
+}

config_test.go

@@ -0,0 +1,36 @@
+// Copyright 2025 FishGoddess. All rights reserved.
+// Use of this source code is governed by a MIT style
+// license that can be found in the LICENSE file.
+
+package goes
+
+import "testing"
+
+// go test -v -cover -run=^TestNewDefaultConfig$
+func TestNewDefaultConfig(t *testing.T) {
+	size := 16
+	conf := newDefaultConfig(size)
+
+	if conf.size != size {
+		t.Fatalf("conf.size %d != size %d", conf.size, size)
+	}
+}
+
+// go test -v -cover -run=^TestConfigRecover$
+func TestConfigRecover(t *testing.T) {
+	size := 16
+	conf := newDefaultConfig(size)
+	conf.recover(0)
+
+	got := 0
+	conf.recoverFunc = func(r any) {
+		got = r.(int)
+	}
+
+	want := 1
+	conf.recover(want)
+
+	if got != want {
+		t.Fatalf("got %d != want %d", got, want)
+	}
+}

option.go

@@ -4,20 +4,6 @@
 
 package goes
 
-type config struct {
-	size        int
-	queueSize   int
-	recoverFunc func(r any)
-}
-
-func newDefaultConfig(size int) *config {
-	return &config{
-		size:        size,
-		queueSize:   64,
-		recoverFunc: nil,
-	}
-}
-
 // Option is for setting config.
 type Option func(conf *config)
 

option_test.go

@@ -9,16 +9,6 @@ import (
 	"testing"
 )
 
-// go test -v -cover -run=^TestNewDefaultConfig$
-func TestNewDefaultConfig(t *testing.T) {
-	size := 16
-	conf := newDefaultConfig(size)
-
-	if conf.size != size {
-		t.Fatalf("conf.size %d != size %d", conf.size, size)
-	}
-}
-
 // go test -v -cover -run=^TestWithQueueSize$
 func TestWithQueueSize(t *testing.T) {
 	size := 16

pool.go

@@ -62,9 +62,7 @@ func (p *Pool) Submit(task func()) {
 	worker := p.workers[p.index]
 	worker.Accept(task)
 
-	p.index++
-
-	if p.index >= len(p.workers) {
+	if p.index++; p.index >= len(p.workers) {
 		p.index = 0
 	}
 }

worker.go

@@ -10,27 +10,19 @@ type worker struct {
 }
 
 func newWorker(pool *Pool) *worker {
-	w := &worker{
-		pool:  pool,
-		tasks: make(chan func(), pool.conf.queueSize),
-	}
+	tasks := make(chan func(), pool.conf.queueSize)
 
+	w := &worker{pool: pool, tasks: tasks}
 	w.work()
 	return w
 }
 
 func (w *worker) handle(task func()) {
-	if task == nil {
-		return
-	}
-
-	if w.pool.conf.recoverFunc != nil {
-		defer func() {
-			if r := recover(); r != nil {
-				w.pool.conf.recoverFunc(r)
-			}
-		}()
-	}
+	defer func() {
+		if r := recover(); r != nil {
+			w.pool.conf.recover(r)
+		}
+	}()
 
 	task()
 }
@@ -52,6 +44,7 @@ func (w *worker) work() {
 	}()
 }
 
+// Accept accepts a task to be handled.
 func (w *worker) Accept(task func()) {
 	if task == nil {
 		return
@@ -60,6 +53,7 @@ func (w *worker) Accept(task func()) {
 	w.tasks <- task
 }
 
+// Done signals the worker to stop working.
 func (w *worker) Done() {
 	w.tasks <- nil
 }