Skip to content

Commit 8d19e96

Browse files
khvn26khvn26
authored
feat!: Remove FeatureContext.feature_key, SegmentResult.key (#33)
1 parent 6b38158 commit 8d19e96

File tree

152 files changed

+1545
-1592
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

152 files changed

+1545
-1592
lines changed

‎test_cases/test_042b3a46-4575-419a-8a2f-62baa3226668__default.json‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,28 +8,28 @@
88
"features": {
99
"basic_flag": {
1010
"enabled": false,
11-
"feature_key": "15060",
11+
"metadata": {"id": 15060},
1212
"key": "78982",
1313
"name": "basic_flag",
1414
"value": ""
1515
},
1616
"float_feature": {
1717
"enabled": true,
18-
"feature_key": "15061",
18+
"metadata": {"id": 15061},
1919
"key": "78984",
2020
"name": "float_feature",
2121
"value": "12.34"
2222
},
2323
"integer_feature": {
2424
"enabled": true,
25-
"feature_key": "15059",
25+
"metadata": {"id": 15059},
2626
"key": "78980",
2727
"name": "integer_feature",
2828
"value": 1234
2929
},
3030
"mv_feature": {
3131
"enabled": true,
32-
"feature_key": "15062",
32+
"metadata": {"id": 15062},
3333
"key": "78986",
3434
"name": "mv_feature",
3535
"value": "foo",
@@ -58,7 +58,7 @@
5858
},
5959
"string_feature": {
6060
"enabled": true,
61-
"feature_key": "15058",
61+
"metadata": {"id": 15058},
6262
"key": "78978",
6363
"name": "string_feature",
6464
"value": "foo"
@@ -79,7 +79,7 @@
7979
"overrides": [
8080
{
8181
"enabled": true,
82-
"feature_key": "15058",
82+
"metadata": {"id": 15058},
8383
"key": "78978",
8484
"name": "string_feature",
8585
"priority": 0,
@@ -117,7 +117,7 @@
117117
"overrides": [
118118
{
119119
"enabled": true,
120-
"feature_key": "15058",
120+
"metadata": {"id": 15058},
121121
"key": "78977",
122122
"name": "string_feature",
123123
"priority": 1,
@@ -155,7 +155,7 @@
155155
"overrides": [
156156
{
157157
"enabled": true,
158-
"feature_key": "15058",
158+
"metadata": {"id": 15058},
159159
"key": "81027",
160160
"name": "string_feature",
161161
"value": "context_values"
@@ -192,7 +192,7 @@
192192
"overrides": [
193193
{
194194
"enabled": false,
195-
"feature_key": "15058",
195+
"metadata": {"id": 15058},
196196
"key": "81027",
197197
"name": "string_feature",
198198
"value": "segment_override"
@@ -251,7 +251,7 @@
251251
"overrides": [
252252
{
253253
"enabled": true,
254-
"feature_key": "15060",
254+
"metadata": {"id": 15060},
255255
"key": "81026",
256256
"name": "basic_flag",
257257
"value": ""
@@ -283,35 +283,35 @@
283283
"flags": {
284284
"basic_flag": {
285285
"enabled": false,
286-
"feature_key": "15060",
286+
"metadata": {"id": 15060},
287287
"name": "basic_flag",
288288
"reason": "DEFAULT",
289289
"value": ""
290290
},
291291
"float_feature": {
292292
"enabled": true,
293-
"feature_key": "15061",
293+
"metadata": {"id": 15061},
294294
"name": "float_feature",
295295
"reason": "DEFAULT",
296296
"value": "12.34"
297297
},
298298
"integer_feature": {
299299
"enabled": true,
300-
"feature_key": "15059",
300+
"metadata": {"id": 15059},
301301
"name": "integer_feature",
302302
"reason": "DEFAULT",
303303
"value": 1234
304304
},
305305
"mv_feature": {
306306
"enabled": true,
307-
"feature_key": "15062",
307+
"metadata": {"id": 15062},
308308
"name": "mv_feature",
309309
"reason": "DEFAULT",
310310
"value": "foo"
311311
},
312312
"string_feature": {
313313
"enabled": true,
314-
"feature_key": "15058",
314+
"metadata": {"id": 15058},
315315
"name": "string_feature",
316316
"reason": "DEFAULT",
317317
"value": "foo"

‎test_cases/test_0cfd0d72-4de4-4ed7-9cfb-d80dc3dacead__default.json‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,28 +8,28 @@
88
"features": {
99
"basic_flag": {
1010
"enabled": false,
11-
"feature_key": "15060",
11+
"metadata": {"id": 15060},
1212
"key": "78982",
1313
"name": "basic_flag",
1414
"value": ""
1515
},
1616
"float_feature": {
1717
"enabled": true,
18-
"feature_key": "15061",
18+
"metadata": {"id": 15061},
1919
"key": "78984",
2020
"name": "float_feature",
2121
"value": "12.34"
2222
},
2323
"integer_feature": {
2424
"enabled": true,
25-
"feature_key": "15059",
25+
"metadata": {"id": 15059},
2626
"key": "78980",
2727
"name": "integer_feature",
2828
"value": 1234
2929
},
3030
"mv_feature": {
3131
"enabled": true,
32-
"feature_key": "15062",
32+
"metadata": {"id": 15062},
3333
"key": "78986",
3434
"name": "mv_feature",
3535
"value": "foo",
@@ -58,7 +58,7 @@
5858
},
5959
"string_feature": {
6060
"enabled": true,
61-
"feature_key": "15058",
61+
"metadata": {"id": 15058},
6262
"key": "78978",
6363
"name": "string_feature",
6464
"value": "foo"
@@ -79,7 +79,7 @@
7979
"overrides": [
8080
{
8181
"enabled": true,
82-
"feature_key": "15058",
82+
"metadata": {"id": 15058},
8383
"key": "78978",
8484
"name": "string_feature",
8585
"priority": 0,
@@ -117,7 +117,7 @@
117117
"overrides": [
118118
{
119119
"enabled": true,
120-
"feature_key": "15058",
120+
"metadata": {"id": 15058},
121121
"key": "78977",
122122
"name": "string_feature",
123123
"priority": 1,
@@ -155,7 +155,7 @@
155155
"overrides": [
156156
{
157157
"enabled": true,
158-
"feature_key": "15058",
158+
"metadata": {"id": 15058},
159159
"key": "81027",
160160
"name": "string_feature",
161161
"value": "context_values"
@@ -192,7 +192,7 @@
192192
"overrides": [
193193
{
194194
"enabled": false,
195-
"feature_key": "15058",
195+
"metadata": {"id": 15058},
196196
"key": "81027",
197197
"name": "string_feature",
198198
"value": "segment_override"
@@ -251,7 +251,7 @@
251251
"overrides": [
252252
{
253253
"enabled": true,
254-
"feature_key": "15060",
254+
"metadata": {"id": 15060},
255255
"key": "81026",
256256
"name": "basic_flag",
257257
"value": ""
@@ -283,35 +283,35 @@
283283
"flags": {
284284
"basic_flag": {
285285
"enabled": false,
286-
"feature_key": "15060",
286+
"metadata": {"id": 15060},
287287
"name": "basic_flag",
288288
"reason": "DEFAULT",
289289
"value": ""
290290
},
291291
"float_feature": {
292292
"enabled": true,
293-
"feature_key": "15061",
293+
"metadata": {"id": 15061},
294294
"name": "float_feature",
295295
"reason": "DEFAULT",
296296
"value": "12.34"
297297
},
298298
"integer_feature": {
299299
"enabled": true,
300-
"feature_key": "15059",
300+
"metadata": {"id": 15059},
301301
"name": "integer_feature",
302302
"reason": "DEFAULT",
303303
"value": 1234
304304
},
305305
"mv_feature": {
306306
"enabled": true,
307-
"feature_key": "15062",
307+
"metadata": {"id": 15062},
308308
"name": "mv_feature",
309309
"reason": "SPLIT; weight=30",
310310
"value": "baz"
311311
},
312312
"string_feature": {
313313
"enabled": true,
314-
"feature_key": "15058",
314+
"metadata": {"id": 15058},
315315
"name": "string_feature",
316316
"reason": "DEFAULT",
317317
"value": "foo"

‎test_cases/test_0d0eb3b4-aab5-4a2e-b82a-47e84c57c64d__default.json‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -8,28 +8,28 @@
88
"features": {
99
"basic_flag": {
1010
"enabled": false,
11-
"feature_key": "15060",
11+
"metadata": {"id": 15060},
1212
"key": "78982",
1313
"name": "basic_flag",
1414
"value": ""
1515
},
1616
"float_feature": {
1717
"enabled": true,
18-
"feature_key": "15061",
18+
"metadata": {"id": 15061},
1919
"key": "78984",
2020
"name": "float_feature",
2121
"value": "12.34"
2222
},
2323
"integer_feature": {
2424
"enabled": true,
25-
"feature_key": "15059",
25+
"metadata": {"id": 15059},
2626
"key": "78980",
2727
"name": "integer_feature",
2828
"value": 1234
2929
},
3030
"mv_feature": {
3131
"enabled": true,
32-
"feature_key": "15062",
32+
"metadata": {"id": 15062},
3333
"key": "78986",
3434
"name": "mv_feature",
3535
"value": "foo",
@@ -58,7 +58,7 @@
5858
},
5959
"string_feature": {
6060
"enabled": true,
61-
"feature_key": "15058",
61+
"metadata": {"id": 15058},
6262
"key": "78978",
6363
"name": "string_feature",
6464
"value": "foo"
@@ -79,7 +79,7 @@
7979
"overrides": [
8080
{
8181
"enabled": true,
82-
"feature_key": "15058",
82+
"metadata": {"id": 15058},
8383
"key": "78978",
8484
"name": "string_feature",
8585
"priority": 0,
@@ -117,7 +117,7 @@
117117
"overrides": [
118118
{
119119
"enabled": true,
120-
"feature_key": "15058",
120+
"metadata": {"id": 15058},
121121
"key": "78977",
122122
"name": "string_feature",
123123
"priority": 1,
@@ -155,7 +155,7 @@
155155
"overrides": [
156156
{
157157
"enabled": true,
158-
"feature_key": "15058",
158+
"metadata": {"id": 15058},
159159
"key": "81027",
160160
"name": "string_feature",
161161
"value": "context_values"
@@ -192,7 +192,7 @@
192192
"overrides": [
193193
{
194194
"enabled": false,
195-
"feature_key": "15058",
195+
"metadata": {"id": 15058},
196196
"key": "81027",
197197
"name": "string_feature",
198198
"value": "segment_override"
@@ -251,7 +251,7 @@
251251
"overrides": [
252252
{
253253
"enabled": true,
254-
"feature_key": "15060",
254+
"metadata": {"id": 15060},
255255
"key": "81026",
256256
"name": "basic_flag",
257257
"value": ""
@@ -283,35 +283,35 @@
283283
"flags": {
284284
"basic_flag": {
285285
"enabled": false,
286-
"feature_key": "15060",
286+
"metadata": {"id": 15060},
287287
"name": "basic_flag",
288288
"reason": "DEFAULT",
289289
"value": ""
290290
},
291291
"float_feature": {
292292
"enabled": true,
293-
"feature_key": "15061",
293+
"metadata": {"id": 15061},
294294
"name": "float_feature",
295295
"reason": "DEFAULT",
296296
"value": "12.34"
297297
},
298298
"integer_feature": {
299299
"enabled": true,
300-
"feature_key": "15059",
300+
"metadata": {"id": 15059},
301301
"name": "integer_feature",
302302
"reason": "DEFAULT",
303303
"value": 1234
304304
},
305305
"mv_feature": {
306306
"enabled": true,
307-
"feature_key": "15062",
307+
"metadata": {"id": 15062},
308308
"name": "mv_feature",
309309
"reason": "SPLIT; weight=30",
310310
"value": "baz"
311311
},
312312
"string_feature": {
313313
"enabled": true,
314-
"feature_key": "15058",
314+
"metadata": {"id": 15058},
315315
"name": "string_feature",
316316
"reason": "DEFAULT",
317317
"value": "foo"

0 commit comments

Comments
 (0)