fix: typed-dict-metadata-item

Author: Zaimwa9

src/common/metadata/serializers.py

@@ -5,6 +5,8 @@
 from django.db import models
 from rest_framework import serializers
 
+from common.metadata.types import MetadataItem
+
 if typing.TYPE_CHECKING:
     from common.types import (
         Metadata,  # noqa: F401
@@ -59,7 +61,7 @@ def get_required_for_object(
     def update_metadata(
         self,
         instance: models.Model,
-        metadata_data: list[dict[str, typing.Any]],
+        metadata_data: list[MetadataItem],
     ) -> None:
         Metadata = apps.get_model("metadata", "Metadata")
         ContentType = apps.get_model("contenttypes", "ContentType")
@@ -83,7 +85,7 @@ def update_metadata(
 
         for metadata_item in metadata_data:
             metadata_model_field = metadata_item.pop("model_field", None)
-            if metadata_model_field.id is not None:
+            if metadata_model_field is not None and metadata_model_field.id is not None:
                 Metadata.objects.update_or_create(
                     model_field=metadata_model_field,
                     content_type=content_type,

src/common/metadata/types.py

@@ -0,0 +1,10 @@
+from typing import TypedDict, Any, NotRequired, Protocol
+from django.contrib.contenttypes.models import ContentType
+
+class HasId(Protocol):
+    id: int 
+
+class MetadataItem(TypedDict, total=False):
+    model_field: HasId
+    field_value: Any
+    delete: NotRequired[bool]