Improve test coverage

Author: emyller

src/task_processor/apps.py

@@ -39,10 +39,8 @@ def _validate_database_settings(self) -> None:
                 "DATABASES must include 'task_processor' when using a separate task processor database."
             )
 
-        if (
-            "task_processor.routers.TaskProcessorRouter"
-            not in settings.DATABASE_ROUTERS
-        ):
+        router_name = "task_processor.routers.TaskProcessorRouter"
+        if router_name not in settings.DATABASE_ROUTERS:
             raise ImproperlyConfigured(
                 "DATABASE_ROUTERS must include 'task_processor.routers.TaskProcessorRouter' "
                 "when using a separate task processor database."

tests/unit/task_processor/test_unit_task_processor_apps.py

@@ -6,6 +6,52 @@
 from pytest_mock import MockerFixture
 
 from task_processor import apps
+from task_processor.health import TaskProcessorHealthCheckBackend
+from task_processor.task_run_method import TaskRunMethod
+
+
+def test_skips_validation_if_task_run_method_is_not_task_processor(
+    mocker: MockerFixture,
+    settings: SettingsWrapper,
+) -> None:
+    # Given
+    settings.TASK_RUN_METHOD = TaskRunMethod.SYNCHRONOUSLY
+    task_processor_app = mocker.Mock()
+
+    # When
+    apps.TaskProcessorAppConfig.ready(task_processor_app)
+
+    # Then
+    task_processor_app._validate_database_settings.assert_not_called()
+    task_processor_app._register_health_check.assert_not_called()
+
+
+@pytest.mark.parametrize(
+    "enabled, expected_call",
+    [
+        (True, ((TaskProcessorHealthCheckBackend,), {})),
+        (False, None),
+    ],
+)
+def test_registers_health_check_if_enabled(
+    enabled: bool,
+    mocker: MockerFixture,
+    expected_call: tuple[typing.Any, ...],
+    settings: SettingsWrapper,
+) -> None:
+    # Given
+    settings.TASK_RUN_METHOD = TaskRunMethod.TASK_PROCESSOR
+    settings.ENABLE_TASK_PROCESSOR_HEALTH_CHECK = enabled
+    plugin_dir = mocker.patch.object(apps, "plugin_dir")
+    task_processor_app = mocker.Mock()
+
+    # When
+    apps.TaskProcessorAppConfig.ready(task_processor_app)
+    apps.TaskProcessorAppConfig._register_health_check(task_processor_app)
+
+    # Then
+    task_processor_app._register_health_check.assert_called_once_with()
+    assert plugin_dir.register.call_args == expected_call
 
 
 @pytest.mark.parametrize(

tests/unit/task_processor/test_unit_task_processor_routers.py

@@ -10,7 +10,7 @@
 
 
 @pytest.mark.parametrize("model", apps.get_app_config("task_processor").get_models())
-def test_TaskProcessorRouter__enabled__routes_queries_to_task_processor_database(
+def test_TaskProcessorRouter_routes_queries_to_task_processor_database(
     mocker: MockerFixture,
     model: type[Model],
 ) -> None:
@@ -25,6 +25,21 @@ def test_TaskProcessorRouter__enabled__routes_queries_to_task_processor_database
     assert read_database == write_database == "task_processor"
 
 
+def test_TaskProcessorRouter_does_not_affect_non_task_processor_models(
+    mocker: MockerFixture,
+) -> None:
+    # Given
+    model = apps.get_model(settings.AUTH_USER_MODEL)
+    router = routers.TaskProcessorRouter()
+
+    # When
+    read_database = router.db_for_read(model)
+    write_database = router.db_for_write(model)
+
+    # Then
+    assert read_database is write_database is None
+
+
 @pytest.mark.parametrize(
     "model1, model2, expected",
     [  # True if both models are from task_processor app
@@ -38,7 +53,7 @@ def test_TaskProcessorRouter__enabled__routes_queries_to_task_processor_database
         for model in apps.get_app_config("task_processor").get_models()
     ],
 )
-def test_TaskProcessorRouter__allow_relation__returns_according_to_given_models(
+def test_TaskProcessorRouter_allows_relation_among_task_processor_models(
     mocker: MockerFixture,
     model1: type[Model],
     model2: type[Model],
@@ -65,7 +80,7 @@ def test_TaskProcessorRouter__allow_relation__returns_according_to_given_models(
         ("other", "other", None),
     ],
 )
-def test_TaskProcessorRouter__allow_migrate__applies_to_both_databases(
+def test_TaskProcessorRouter_applies_migrations_to_both_databases(
     app_label: str,
     database: str,
     expected: bool,