avoid circular imports, fix tests

Author: khvn26

src/common/prometheus/constants.py renamed to src/common/core/constants.py

@@ -11,7 +11,7 @@
 from environs import Env
 
 from common.core.cli import healthcheck
-from common.prometheus.constants import DEFAULT_PROMETHEUS_MULTIPROC_DIR
+from common.core.constants import DEFAULT_PROMETHEUS_MULTIPROC_DIR
 
 logger = logging.getLogger(__name__)
 

src/common/core/main.py

@@ -1,6 +1,4 @@
-import os
 import subprocess
-from pathlib import Path
 
 import django
 import pytest
@@ -111,32 +109,43 @@ def test_main__healthcheck_http__server_invalid_response__runs_expected(
         main(argv)
 
 
-def test_main__prometheus_multiproc_remove_dir_on_exit_default__expected(
+def test_main__prometheus_multiproc_remove_dir_on_start_default__expected(
     monkeypatch: pytest.MonkeyPatch,
+    fs: FakeFilesystem,
 ) -> None:
     # Given
     monkeypatch.delenv("PROMETHEUS_MULTIPROC_DIR_KEEP", raising=False)
 
+    fs.create_file(
+        "/tmp/flagsmith-prometheus/some_metric_file.db",
+        create_missing_dirs=True,
+    )
+
     # When
     main(["flagsmith"])
 
     # Then
-    assert not Path(os.environ["PROMETHEUS_MULTIPROC_DIR"]).exists()
+    assert not fs.exists("/tmp/flagsmith-prometheus/some_metric_file.db")
 
 
-def test_main__prometheus_multiproc_remove_dir_on_exit_true__expected(
+def test_main__prometheus_multiproc_remove_dir_on_start_true__expected(
     monkeypatch: pytest.MonkeyPatch,
     fs: FakeFilesystem,
 ) -> None:
     # Given
-    monkeypatch.delenv("PROMETHEUS_MULTIPROC_DIR")
+    monkeypatch.delenv("PROMETHEUS_MULTIPROC_DIR", raising=False)
     monkeypatch.setenv("PROMETHEUS_MULTIPROC_DIR_KEEP", "true")
 
+    fs.create_file(
+        "/tmp/flagsmith-prometheus/some_metric_file.db",
+        create_missing_dirs=True,
+    )
+
     # When
     main(["flagsmith"])
 
     # Then
-    assert Path(os.environ["PROMETHEUS_MULTIPROC_DIR"]).exists()
+    assert fs.exists("/tmp/flagsmith-prometheus/some_metric_file.db")
 
 
 def test_main__no_django_configured__expected_0(