Skip to content

Commit 469c085

Browse files
authored
Merge pull request #155 from Flagsmith/fix/request-timeout
fix: Fix default request timeout being 0
2 parents baa6aba + 6a81c35 commit 469c085

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

Flagsmith.Client.Test/FlagsmithTest.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -833,5 +833,11 @@ public void TestRequestTimeoutInterpretsSecondsCorrectly()
833833
};
834834
Assert.Equal(100, config.RequestTimeout);
835835
}
836+
837+
[Fact]
838+
public void TestRequestTimeoutHasReasonableDefault()
839+
{
840+
Assert.True(new FlagsmithConfiguration().RequestTimeout > 1);
841+
}
836842
}
837843
}

Flagsmith.FlagsmithClient/Flagsmith.FlagsmithClient.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
<Project Sdk="Microsoft.NET.Sdk">
2-
2+
33
<PropertyGroup>
44
<TargetFramework>netstandard2.0</TargetFramework>
55
<LangVersion>8</LangVersion>
66
<DefaultItemExcludes>$(DefaultItemExcludes);example/**;</DefaultItemExcludes>
77
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
88
<PackageId>Flagsmith</PackageId>
99
<Title>Flagsmith</Title>
10-
<Version>8.0.0</Version>
10+
<Version>8.0.1</Version>
1111
<Authors>flagsmith</Authors>
1212
<Company>Flagsmith</Company>
1313
<PackageDescription>Client SDK for Flagsmith. Ship features with confidence using feature flags and remote config. Host yourself or use our hosted version at https://flagsmith.com/</PackageDescription>

Flagsmith.FlagsmithClient/FlagsmithConfiguration.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace Flagsmith
99
public class FlagsmithConfiguration
1010
{
1111
private static readonly Uri DefaultApiUri = new Uri("https://edge.api.flagsmith.com/api/v1/");
12-
private TimeSpan _timeout;
12+
private TimeSpan _timeout = TimeSpan.FromSeconds(5);
1313

1414
/// <summary>
1515
/// Versioned base Flagsmith API URI to use for all requests. Defaults to
@@ -54,7 +54,7 @@ public class FlagsmithConfiguration
5454
public Double? RequestTimeout
5555
{
5656
get => _timeout.TotalSeconds;
57-
set => _timeout = TimeSpan.FromSeconds(value ?? 100);
57+
set => _timeout = TimeSpan.FromSeconds(value ?? 5);
5858
}
5959

6060
/// <summary>

0 commit comments

Comments
 (0)