Skip to content

Commit ccb468b

Browse files
authored
Merge branch 'main' into fix/constructor-deadlock
2 parents 0d87a11 + c9bd64b commit ccb468b

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030
- run: dotnet pack --configuration Release --output ${{ env.NuGetDirectory }}
3131

3232
# Publish the NuGet package as an artifact, so they can be used in the following jobs
33-
- uses: actions/upload-artifact@v3
33+
- uses: actions/upload-artifact@v4
3434
with:
3535
name: nuget
3636
if-no-files-found: error
@@ -49,7 +49,7 @@ jobs:
4949
uses: actions/setup-dotnet@v4
5050

5151
# Download the NuGet package created in the previous job
52-
- uses: actions/download-artifact@v3
52+
- uses: actions/download-artifact@v4
5353
with:
5454
name: nuget
5555
path: ${{ env.NuGetDirectory }}
@@ -70,7 +70,7 @@ jobs:
7070
- validate_nuget
7171
steps:
7272
# Download the NuGet package created in the previous job
73-
- uses: actions/download-artifact@v3
73+
- uses: actions/download-artifact@v4
7474
with:
7575
name: nuget
7676
path: ${{ env.NuGetDirectory }}

Flagsmith.FlagsmithClient/AnalyticsProcessor.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public async Task Flush()
7171
_CustomHeaders?.ForEach(kvp => request.Headers.Add(kvp.Key, kvp.Value));
7272
var tokenSource = new CancellationTokenSource();
7373
tokenSource.CancelAfter(TimeSpan.FromSeconds(_TimeOut));
74-
var response = await _HttpClient.SendAsync(request, tokenSource.Token);
74+
var response = await _HttpClient.SendAsync(request, tokenSource.Token).ConfigureAwait(false);
7575
response.EnsureSuccessStatusCode();
7676
_Logger?.LogInformation("Analytics posted: " + analyticsJson);
7777
AnalyticsDataThreads.Clear();
@@ -116,7 +116,7 @@ public async Task TrackFeature(string featureName)
116116
int _LastFlushedInterval = (DateTime.Now - _LastFlushed).Seconds;
117117

118118
if (_LastFlushedInterval > _FlushIntervalSeconds)
119-
await Flush();
119+
await Flush().ConfigureAwait(false);
120120
}
121121

122122
/// <summary>

Flagsmith.FlagsmithClient/Flags.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public async Task<IFlag> GetFlag(string featureName)
2929

3030
}
3131
if (_AnalyticsProcessor != null)
32-
await _AnalyticsProcessor.TrackFeature(flag.GetFeatureName());
32+
await _AnalyticsProcessor.TrackFeature(flag.GetFeatureName()).ConfigureAwait(false);
3333
return flag;
3434
}
3535
public List<IFlag> AllFlags() => _Flags;

0 commit comments

Comments
 (0)