Skip to content

Commit 20d1033

Browse files
author
Matthew Elwell
authored
Release 1.6.2 (#92)
* Bump version 1.6.2 * Fix TypeError when sorting feature segments (#91)
2 parents e510c2b + 9f94ff9 commit 20d1033

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

flag_engine/django_transform/filters.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,6 @@ def sort_and_filter_feature_segments(
4242
)
4343

4444
# TODO: determine why this sorting is necessary
45-
return sorted(feature_segments, key=lambda fs: (fs.feature, Reverser(fs.priority)))
45+
return sorted(
46+
feature_segments, key=lambda fs: (fs.feature_id, Reverser(fs.priority))
47+
)

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
setup(
44
name="flagsmith-flag-engine",
5-
version="1.6.1",
5+
version="1.6.2",
66
author="Flagsmith",
77
author_email="[email protected]",
88
packages=find_packages(include=["flag_engine", "flag_engine.*"]),

tests/unit/django_transform/test_django_transform_filters.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,19 @@ class MockEnvironment:
1212
@dataclass
1313
class MockFeatureSegment:
1414
id: int
15-
feature: int
15+
feature_id: int
1616
priority: int
1717
environment: object
1818

1919
api_key = "api-key"
20-
matching_env = MockEnvironment(api_key=api_key)
21-
not_matching_env = MockEnvironment(api_key="some-other-api-key")
20+
valid_env = MockEnvironment(api_key=api_key)
21+
invalid_env = MockEnvironment(api_key="some-other-api-key")
2222

2323
feature_segments = [
24-
MockFeatureSegment(id=1, feature=2, priority=1, environment=matching_env),
25-
MockFeatureSegment(id=2, feature=2, priority=2, environment=matching_env),
26-
MockFeatureSegment(id=3, feature=1, priority=1, environment=matching_env),
27-
MockFeatureSegment(id=4, feature=1, priority=1, environment=not_matching_env),
24+
MockFeatureSegment(id=1, feature_id=2, priority=1, environment=valid_env),
25+
MockFeatureSegment(id=2, feature_id=2, priority=2, environment=valid_env),
26+
MockFeatureSegment(id=3, feature_id=1, priority=1, environment=valid_env),
27+
MockFeatureSegment(id=4, feature_id=1, priority=1, environment=invalid_env),
2828
]
2929

3030
# When

0 commit comments

Comments
 (0)