Skip to content

Commit ca989b7

Browse files
committed
override tests moved to engine-test-data
1 parent 66e763e commit ca989b7

File tree

3 files changed

+2
-82
lines changed

3 files changed

+2
-82
lines changed

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
[submodule "tests/engine_tests/engine-test-data"]
22
path = tests/engine_tests/engine-test-data
33
url = https://github.com/flagsmith/engine-test-data.git
4-
tag = v2.4.0
4+
branch = feat/feature-metadata

tests/unit/test_engine.py

Lines changed: 0 additions & 80 deletions
Original file line numberDiff line numberDiff line change
@@ -556,83 +556,3 @@ def test_feature_metadata_generic_type__default__returns_expected() -> None:
556556
# Then
557557
assert result["flags"]["feature_1"]["metadata"] is feature_metadata
558558
reveal_type(result["flags"]["feature_1"]["metadata"]) # Mapping[str, object]
559-
560-
561-
def test_feature_metadata__no_override__returns_expected() -> None:
562-
# Given
563-
feature_metadata = {"hello": object()}
564-
565-
evaluation_context: EvaluationContext = {
566-
"environment": {"key": "api-key", "name": ""},
567-
"features": {
568-
"feature_1": {
569-
"key": "1",
570-
"feature_key": "1",
571-
"name": "feature_1",
572-
"enabled": False,
573-
"value": None,
574-
"metadata": feature_metadata,
575-
},
576-
},
577-
}
578-
579-
# When
580-
result = get_evaluation_result(evaluation_context)
581-
582-
# Then
583-
assert result["flags"]["feature_1"]["metadata"] is feature_metadata
584-
585-
586-
def test_feature_metadata__override_has_metadata__returns_expected() -> None:
587-
# Given
588-
default_feature_metadata = {"hello": object()}
589-
override_feature_metadata = {"hello": "override"}
590-
591-
evaluation_context: EvaluationContext = {
592-
"environment": {"key": "api-key", "name": ""},
593-
"features": {
594-
"feature_1": {
595-
"key": "1",
596-
"feature_key": "1",
597-
"name": "feature_1",
598-
"enabled": False,
599-
"value": None,
600-
"metadata": default_feature_metadata,
601-
},
602-
},
603-
"segments": {
604-
"1": {
605-
"key": "1",
606-
"name": "my_segment",
607-
"rules": [
608-
{
609-
"type": "ALL",
610-
"conditions": [
611-
{
612-
"property": "$.environment.name",
613-
"operator": "EQUAL",
614-
"value": "",
615-
}
616-
],
617-
"rules": [],
618-
}
619-
],
620-
"overrides": [
621-
{
622-
"key": "5",
623-
"feature_key": "1",
624-
"name": "feature_1",
625-
"enabled": True,
626-
"value": "overridden_for_identity",
627-
"metadata": override_feature_metadata,
628-
}
629-
],
630-
},
631-
},
632-
}
633-
634-
# When
635-
result = get_evaluation_result(evaluation_context)
636-
637-
# Then
638-
assert result["flags"]["feature_1"]["metadata"] is override_feature_metadata

0 commit comments

Comments
 (0)