Revert change to NewTransientEvaluationContext

Author: rolodato

client_test.go

@@ -212,7 +212,7 @@ func TestGetFlagsTransientIdentity(t *testing.T) {
 	// When
 	client := flagsmith.NewClient(fixtures.EnvironmentAPIKey, flagsmith.WithBaseURL(server.URL+"/api/v1/"))
 
-	flags, err := client.GetFlags(ctx, flagsmith.NewTransientEvaluationContext(map[string]interface{}{}))
+	flags, err := client.GetFlags(ctx, flagsmith.NewTransientEvaluationContext("", map[string]interface{}{}))
 
 	// Then
 	assert.NoError(t, err)

evaluationcontext_static.go

@@ -14,9 +14,9 @@ func NewEvaluationContext(identifier string, traits map[string]interface{}) (ec
 	return ec
 }
 
-// NewTransientEvaluationContext creates an evaluation context using custom traits, but without an associated identity.
+// NewTransientEvaluationContext creates an evaluation context for an identity.
 // If this context is used to evaluate flags remotely, Flagsmith will not persist the traits.
-func NewTransientEvaluationContext(traits map[string]interface{}) EvaluationContext {
+func NewTransientEvaluationContext(identifier string, traits map[string]interface{}) EvaluationContext {
 	ec := NewEvaluationContext("", traits)
 	ec.Identity.Transient = true
 	return ec