revert to pointer EnvironmentModel

Author: rolodato

Makefile

@@ -9,7 +9,7 @@ import (
 )
 
 // GetEnvironmentFeatureStates returns a list of feature states for a given environment.
-func GetEnvironmentFeatureStates(environment environments.EnvironmentModel) []*features.FeatureStateModel {
+func GetEnvironmentFeatureStates(environment *environments.EnvironmentModel) []*features.FeatureStateModel {
 	if environment.Project.HideDisabledFlags {
 		var featureStates []*features.FeatureStateModel
 		for _, fs := range environment.FeatureStates {
@@ -23,7 +23,7 @@ func GetEnvironmentFeatureStates(environment environments.EnvironmentModel) []*f
 }
 
 // GetEnvironmentFeatureState returns a specific feature state for a given featureName in a given environment, or nil feature state is not found.
-func GetEnvironmentFeatureState(environment environments.EnvironmentModel, featureName string) *features.FeatureStateModel {
+func GetEnvironmentFeatureState(environment *environments.EnvironmentModel, featureName string) *features.FeatureStateModel {
 	for _, fs := range environment.FeatureStates {
 		if fs.Feature.Name == featureName {
 			return fs

flagengine/engine.go

@@ -153,7 +153,7 @@ func TestEnvironmentGetFeatureStateFeatureNotFound(t *testing.T) {
 	assert.Nil(t, fs)
 }
 
-func getEnvironmentFeatureStateForFeature(env environments.EnvironmentModel, feature *features.FeatureModel) *features.FeatureStateModel {
+func getEnvironmentFeatureStateForFeature(env *environments.EnvironmentModel, feature *features.FeatureModel) *features.FeatureStateModel {
 	for _, fs := range env.FeatureStates {
 		if fs.Feature == feature {
 			return fs

flagengine/engine_test.go

@@ -43,7 +43,7 @@ func TestEngine(t *testing.T) {
 		t.Run(strconv.Itoa(i)+":"+c.Identity.CompositeKey(), func(t *testing.T) {
 			assert := assert.New(t)
 			require := require.New(t)
-			actual := flagengine.GetIdentityFeatureStates(testData.Environment, &c.Identity)
+			actual := flagengine.GetIdentityFeatureStates(&testData.Environment, &c.Identity)
 			expected := c.Response.Flags
 
 			sort.Slice(actual, func(i, j int) bool {

flagengine/flagengine_integration_test.go

@@ -77,8 +77,8 @@ func Feature2() *features.FeatureModel {
 	}
 }
 
-func Environment(feature1, feature2 *features.FeatureModel, project *projects.ProjectModel) environments.EnvironmentModel {
-	return environments.EnvironmentModel{
+func Environment(feature1, feature2 *features.FeatureModel, project *projects.ProjectModel) *environments.EnvironmentModel {
+	return &environments.EnvironmentModel{
 		ID:      1,
 		APIKey:  "api-key",
 		Project: project,
@@ -89,7 +89,7 @@ func Environment(feature1, feature2 *features.FeatureModel, project *projects.Pr
 	}
 }
 
-func Identity(env environments.EnvironmentModel) *identities.IdentityModel {
+func Identity(env *environments.EnvironmentModel) *identities.IdentityModel {
 	return &identities.IdentityModel{
 		Identifier:        "identity_1",
 		EnvironmentAPIKey: env.APIKey,
@@ -104,15 +104,15 @@ func TraitMatchingSegment(segCond *segments.SegmentConditionModel) *traits.Trait
 	}
 }
 
-func IdentityInSegment(trait *traits.TraitModel, env environments.EnvironmentModel) *identities.IdentityModel {
+func IdentityInSegment(trait *traits.TraitModel, env *environments.EnvironmentModel) *identities.IdentityModel {
 	return &identities.IdentityModel{
 		Identifier:        "identity_2",
 		EnvironmentAPIKey: env.APIKey,
 		IdentityTraits:    []*traits.TraitModel{trait},
 	}
 }
 
-func SegmentOverrideFs(segment *segments.SegmentModel, feature *features.FeatureModel) *features.FeatureStateModel {
+func SegmentOverrideFs(_ *segments.SegmentModel, feature *features.FeatureModel) *features.FeatureStateModel {
 	return &features.FeatureStateModel{
 		DjangoID: 4,
 		Feature:  feature,
@@ -134,16 +134,16 @@ func MVFeatureStateValue() *features.MultivariateFeatureStateValueModel {
 }
 
 func EnvironmentWithSegmentOverride(
-	env environments.EnvironmentModel,
+	env *environments.EnvironmentModel,
 	featureState *features.FeatureStateModel,
 	segment *segments.SegmentModel,
-) environments.EnvironmentModel {
+) *environments.EnvironmentModel {
 	segment.FeatureStates = append(segment.FeatureStates, featureState)
 	env.Project.Segments = append(env.Project.Segments, segment)
 	return env
 }
 
-func GetFixtures() (*features.FeatureModel, *features.FeatureModel, *segments.SegmentModel, environments.EnvironmentModel, *identities.IdentityModel) {
+func GetFixtures() (*features.FeatureModel, *features.FeatureModel, *segments.SegmentModel, *environments.EnvironmentModel, *identities.IdentityModel) {
 	feature1 := Feature1()
 	feature2 := Feature2()
 	org := Organisation()