Skip to content

Commit 7dcb4a0

Browse files
committed
more feedback
1 parent 7d61b9d commit 7dcb4a0

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

client.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ func (c *Client) getIdentityModel(identifier string, apiKey string, traits map[s
341341
identityTraits = append(identityTraits, enginetraits.NewTrait(k, v))
342342
}
343343

344-
if identity, ok := c.state.GetIdentityOverride(identifier); ok {
344+
if identity := c.state.GetIdentityOverride(identifier); identity != nil {
345345
identity.IdentityTraits = identityTraits
346346
return identity
347347
}

state.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,14 @@ func (cs *environmentState) GetEnvironment() *environments.EnvironmentModel {
2323
return cs.environment
2424
}
2525

26-
func (cs *environmentState) GetIdentityOverride(identifier string) (*identities.IdentityModel, bool) {
26+
func (cs *environmentState) GetIdentityOverride(identifier string) *identities.IdentityModel {
2727
cs.mu.RLock()
2828
defer cs.mu.RUnlock()
2929
i, ok := cs.identityOverrides.Load(identifier)
3030
if ok && i != nil {
31-
return i.(*identities.IdentityModel), true
31+
return i.(*identities.IdentityModel)
3232
}
33-
return nil, false
33+
return nil
3434
}
3535

3636
func (cs *environmentState) SetEnvironment(env *environments.EnvironmentModel) {

0 commit comments

Comments
 (0)