explicit linter list, fixes

Author: khvn26

.github/workflows/go.yml

@@ -37,6 +37,9 @@ jobs:
       run: |
         go get -v -t -d ./...
 
+    - name: Lint
+      uses: golangci/golangci-lint-action@v6
+
     - name: Build
       run: go build -v ./...
 

.golangci.yml

@@ -1,17 +1,23 @@
-run:
-  timeout: 3m
-  modules-download-mode: readonly
-
-issues:
-  exclude-dirs:
-    - sample
-
+linters-settings:
+  misspell:
+    locale: UK
 linters:
-  # enable additional linters, that are disabled by default
   enable:
     - contextcheck
+    - errcheck
     - godot
     - gofmt
     - goimports
+    - gosimple
+    - govet
+    - ineffassign
     - misspell
+    - staticcheck
+    - unused
     - whitespace
+  disable-all: true
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0
+run:
+  timeout: 5m

.pre-commit-config.yaml

@@ -3,3 +3,6 @@ repos:
     rev: v1.64.6
     hooks:
       - id: golangci-lint-full
+
+ci:
+  skip: [golangci-lint-full]

client.go

@@ -95,7 +95,7 @@ func NewClient(apiKey string, options ...Option) *Client {
 			go c.pollEnvironment(c.ctxLocalEval)
 		}
 	}
-	// Initialize analytics processor
+	// Initialise analytics processor
 	if c.config.enableAnalytics {
 		c.analyticsProcessor = NewAnalyticsProcessor(c.ctxAnalytics, c.client, c.config.baseURL, nil, c.log)
 	}
@@ -192,8 +192,8 @@ func (c *Client) GetIdentitySegments(identifier string, traits []*Trait) ([]*seg
 // BulkIdentify can be used to create/overwrite identities(with traits) in bulk
 // NOTE: This method only works with Edge API endpoint.
 func (c *Client) BulkIdentify(ctx context.Context, batch []*IdentityTraits) error {
-	if len(batch) > bulkIdentifyMaxCount {
-		msg := fmt.Sprintf("flagsmith: batch size must be less than %d", bulkIdentifyMaxCount)
+	if len(batch) > BulkIdentifyMaxCount {
+		msg := fmt.Sprintf("flagsmith: batch size must be less than %d", BulkIdentifyMaxCount)
 		return &FlagsmithAPIError{Msg: msg}
 	}
 

client_test.go

@@ -10,6 +10,7 @@ import (
 	"sync"
 	"testing"
 	"time"
+
 	flagsmith "github.com/Flagsmith/flagsmith-go-client/v4"
 	"github.com/Flagsmith/flagsmith-go-client/v4/fixtures"
 	"github.com/stretchr/testify/assert"
@@ -199,7 +200,6 @@ func TestGetFlags(t *testing.T) {
 	assert.Equal(t, fixtures.Feature1Name, allFlags[0].FeatureName)
 	assert.Equal(t, fixtures.Feature1ID, allFlags[0].FeatureID)
 	assert.Equal(t, fixtures.Feature1Value, allFlags[0].Value)
-
 }
 
 func TestGetFlagsTransientIdentity(t *testing.T) {

config.go

@@ -12,7 +12,7 @@ const (
 	// Default base URL for the API.
 	DefaultBaseURL = "https://edge.api.flagsmith.com/api/v1/"
 
-	bulkIdentifyMaxCount = 100
+	BulkIdentifyMaxCount   = 100
 	DefaultRealtimeBaseUrl = "https://realtime.flagsmith.com/"
 )
 

evaluation-context-schema-filter.yaml

@@ -0,0 +1,14 @@
+inverseOperationIds:
+  # List operations used by Flagsmith's LaucnhDarkly importer here.
+  - getProject
+  - getEnvironmentsByProject
+  - getFeatureFlags
+  - getTags
+  - getSegments
+unusedComponents:
+  - schemas
+  - parameters
+  - examples
+  - headers
+  - requestBodies
+  - responses

flagengine/environments/models.go

@@ -1,10 +1,11 @@
 package environments
 
 import (
+	"time"
+
 	"github.com/Flagsmith/flagsmith-go-client/v4/flagengine/features"
 	"github.com/Flagsmith/flagsmith-go-client/v4/flagengine/identities"
 	"github.com/Flagsmith/flagsmith-go-client/v4/flagengine/projects"
-	"time"
 )
 
 type EnvironmentModel struct {

flagengine/projects/models.go

@@ -9,6 +9,6 @@ type ProjectModel struct {
 	ID                int                              `json:"id"`
 	Name              string                           `json:"name"`
 	HideDisabledFlags bool                             `json:"hide_disabled_flags"`
-	Organization      *organisations.OrganisationModel `json:"organization"`
+	Organisation      *organisations.OrganisationModel `json:"organisation"`
 	Segments          []*segments.SegmentModel         `json:"segments"`
 }

flagengine/utils/fixtures/fixtures.go

@@ -41,7 +41,7 @@ func Segment(rule *segments.SegmentRuleModel) *segments.SegmentModel {
 	}
 }
 
-func Organization() *organisations.OrganisationModel {
+func Organisation() *organisations.OrganisationModel {
 	return &organisations.OrganisationModel{
 		ID:               1,
 		Name:             "test Org",
@@ -55,7 +55,7 @@ func Project(org *organisations.OrganisationModel, segment *segments.SegmentMode
 	return &projects.ProjectModel{
 		ID:                1,
 		Name:              "Test Project",
-		Organization:      org,
+		Organisation:      org,
 		HideDisabledFlags: false,
 		Segments:          []*segments.SegmentModel{segment},
 	}
@@ -146,7 +146,7 @@ func EnvironmentWithSegmentOverride(
 func GetFixtures() (*features.FeatureModel, *features.FeatureModel, *segments.SegmentModel, *environments.EnvironmentModel, *identities.IdentityModel) {
 	feature1 := Feature1()
 	feature2 := Feature2()
-	org := Organization()
+	org := Organisation()
 	cond := SegmentCondition()
 	rule := SegmentRule(cond)
 	segment := Segment(rule)