Skip to content

Commit ce4c773

Browse files
authored
Upgrade / migrate to UI Kit 2 (#21)
* update node config * first pass upgrade to UI Kit 2 * move API key to server-side * update ADRs * try to reconcile linting * further linting * further linting * further linting * further linting * further linting * GOOD GRIEF * table buffing * add permission checks * add TODO * restore override counts * possibly Strong should be inside Text * no that messes up the layout
1 parent 5b71476 commit ce4c773

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+18765
-8026
lines changed

.eslintignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
package.json
2+
package-lock.json

.eslintrc

Lines changed: 0 additions & 27 deletions
This file was deleted.

flagsmith-jira-app/.eslintrc renamed to .eslintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
},
2424
"settings": {
2525
"react": {
26-
"version": "17"
26+
"version": "18"
2727
}
2828
}
2929
}

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/node_modules/
1+
**/node_modules/
22
/dist/
33
/.vscode/
44
.idea

.npmrc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
engine-strict=true
2-
save-exact=true

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v20.9.0
1+
v22.14.0

.pre-commit-config.yaml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,12 @@ repos:
1515
rev: v8.55.0
1616
hooks:
1717
- id: eslint
18+
files: \.[jt]sx?$ # *.js, *.jsx, *.ts and *.tsx
19+
types: [file]
1820
additional_dependencies:
19-
20-
21-
22-
23-
exclude: |
24-
(?x)^(
25-
package.json|
26-
tests/.*
27-
)$
21+
- "@typescript-eslint/eslint-plugin@^6.11.0"
22+
- "eslint@^8.56.0"
23+
- "eslint-config-prettier@^9.0.0"
24+
- "eslint-plugin-prettier@^5.0.1"
25+
- "eslint-plugin-react@^7.33.2"
26+
- "eslint-plugin-react-hooks@^4.6.0"

.tool-versions

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
nodejs 20.9.0
1+
nodejs 22.14.0

README.md

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ instructions but diverge for reproducability and portability reasons.
1717

1818
### Before you begin
1919

20-
Forge CLI requires [Docker](https://docs.docker.com/get-docker/) and Node.js 20 (LTS) to be installed:
20+
Forge CLI requires [Docker](https://docs.docker.com/get-docker/) and Node.js 22 (LTS) to be installed:
2121

2222
- [Apple macOS](https://developer.atlassian.com/platform/forge/installing-forge-on-macos)
2323
- [Linux](https://developer.atlassian.com/platform/forge/installing-forge-on-linux)
@@ -31,10 +31,15 @@ commands:
3131
### Install the Forge CLI
3232

3333
Forge instructions start by
34-
[installing the CLI globally](https://developer.atlassian.com/platform/forge/getting-started/#install-the-forge-cli) but
35-
instead we will use a local installation with pinned requirements:
36-
37-
npm i @forge/cli -g
34+
[installing the CLI globally](https://developer.atlassian.com/platform/forge/getting-started/#install-the-forge-cli)
35+
but you can install it locally if you prefer:
36+
37+
# install the CLI globally...
38+
npm i @forge/cli@11 -g
39+
# then install local dependencies
40+
npm ci --include=dev
41+
# ...or install the CLI locally
42+
npm i @forge/cli@11 --no-save
3843

3944
The Forge CLI is then available by typing `npx forge`.
4045

docs/decisions/0001-use-atlassian-forge.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Atlassian Marketplace.
1010
## Decision Drivers
1111

1212
- Overall requirement to quickly tick the box that Flagsmith has a Jira integration and offer MVP functionality which
13-
can be iterated on later.
13+
can be iterated on later
1414

1515
## Considered Options
1616

@@ -37,4 +37,4 @@ capacity to scale to meet future requirements.
3737

3838
## Links
3939

40-
- https://developer.atlassian.com/developer-guide/cloud-development-options/
40+
- <https://developer.atlassian.com/developer-guide/cloud-development-options/>

0 commit comments

Comments
 (0)