Include getFeatureFlags

Author: rolodato

FlagsmithClient/src/main/java/com/flagsmith/Flagsmith.kt

@@ -116,7 +116,7 @@ class Flagsmith constructor(
                     result(it.map { response -> response.flags })
                 }).also { lastUsedIdentity = identity }
             } else {
-                retrofit.getIdentityFlagsAndTraits(identity, transient).enqueueWithResult { res ->
+                retrofit.getIdentityFlagsAndTraits(identity, if (transient) true else null).enqueueWithResult { res ->
                     flagUpdateFlow.tryEmit(res.getOrNull()?.flags ?: emptyList())
                     result(res.map { it.flags })
                 }

FlagsmithClient/src/test/java/com/flagsmith/FeatureFlagTests.kt

@@ -240,4 +240,23 @@ class FeatureFlagTests {
             assertTrue(result.isSuccess)
         }
     }
+
+    @Test
+    fun testGetFeatureFlagsWithNullTraitsHasNoTransientParam() {
+        mockServer.mockResponseFor(MockEndpoint.GET_IDENTITIES)
+
+        runBlocking {
+            flagsmith.getFeatureFlagsSync("", null, false)
+            val requests = mockServer.retrieveRecordedRequests(
+                request()
+                    .withPath("/identities/")
+                    .withMethod("GET")
+            )
+            assertEquals(1, requests.size)
+            val request = requests[0]
+            val transientParam = request.queryStringParameterList.find { it.name.toString() == "transient" }
+            assertNull("transient parameter should not be present", transientParam)
+        }
+    }
+
 }

FlagsmithClient/src/test/java/com/flagsmith/IdentityTests.kt

@@ -58,21 +58,6 @@ class IdentityTests {
         }
     }
 
-    @Test(expected = AssertionError::class)
-    fun testGetIdentityWithExpectedParameterMissing() {
-        mockServer.mockResponseFor(MockEndpoint.GET_IDENTITIES)
-        runBlocking {
-            flagsmith.getIdentitySync("person")
-
-            mockServer.verify(
-                request()
-                    .withPath("/identities/")
-                    .withMethod("GET")
-                    .withQueryStringParameter("transient")
-            )
-        }
-    }
-
     @Test
     fun testGetIdentityWithoutTransientParameter() {
         mockServer.mockResponseFor(MockEndpoint.GET_IDENTITIES)