feat: implemented-implicit-identity-key (#211)

Author: Zaimwa9

.gitmodules

@@ -1,4 +1,4 @@
 [submodule "tests/engine/engine-tests/engine-test-data"]
 	path = tests/engine/engine-tests/engine-test-data
 	url = [email protected]:Flagsmith/engine-test-data.git
-	branch = v3.0.0
+	branch = v3.1.0

flagsmith-engine/evaluation/evaluationContext/mappers.ts

@@ -116,11 +116,16 @@ function mapIdentityModelToIdentityContext(
         traitsContext[trait.traitKey] = trait.traitValue;
     }
 
-    return {
+    const identityContext: IdentityContext = {
         identifier: identity.identifier,
-        key: identity.djangoID?.toString() || identity.compositeKey,
         traits: traitsContext
     };
+
+    if (identity.djangoID !== undefined) {
+        identityContext.key = identity.djangoID.toString();
+    }
+
+    return identityContext;
 }
 
 function mapSegmentRuleModelToRule(rule: any): any {

flagsmith-engine/index.ts

@@ -6,7 +6,7 @@ import {
     CustomFeatureMetadata,
     FlagResultWithMetadata
 } from './evaluation/models.js';
-import { getIdentitySegments } from './segments/evaluators.js';
+import { getIdentitySegments, getIdentityKey } from './segments/evaluators.js';
 import { EvaluationResultFlags } from './evaluation/models.js';
 import { TARGETING_REASONS } from './features/types.js';
 import { getHashedPercentageForObjIds } from './utils/hashing/index.js';
@@ -131,7 +131,7 @@ export function evaluateFeatures(
 
         const { value: evaluatedValue, reason: evaluatedReason } = hasOverride
             ? { value: finalFeature.value, reason: undefined }
-            : evaluateFeatureValue(finalFeature, context.identity?.key);
+            : evaluateFeatureValue(finalFeature, getIdentityKey(context));
 
         flags[finalFeature.name] = {
             name: finalFeature.name,

flagsmith-engine/segments/evaluators.ts

@@ -49,7 +49,7 @@ export function traitsMatchSegmentCondition(
 ): boolean {
     if (condition.operator === PERCENTAGE_SPLIT) {
         const contextValueKey =
-            getContextValue(condition.property, context) || context?.identity?.key;
+            getContextValue(condition.property, context) || getIdentityKey(context);
         const hashedPercentage = getHashedPercentageForObjIds([segmentKey, contextValueKey]);
         return hashedPercentage <= parseFloat(String(condition.value));
     }
@@ -173,3 +173,9 @@ export function getContextValue(jsonPath: string, context?: GenericEvaluationCon
         return undefined;
     }
 }
+
+export function getIdentityKey(context?: GenericEvaluationContext): string | undefined {
+    if (!context?.identity) return undefined;
+
+    return context.identity.key || `${context.environment.key}_${context.identity.identifier}`;
+}