Improve clarity

Author: emyller

src/Utils/Mappers.php

@@ -165,7 +165,7 @@ private static function _mapIdentityOverridesToSegments($identityOverrides)
         $segments = [];
         foreach ($featuresToIdentifiers as $serializedOverridesKey => $identifiers) {
             $segment = new SegmentContext();
-            $segment->key = hash('sha256', $serializedOverridesKey);
+            $segment->key = '';  // Not used in identity overrides
             $segment->name = 'identity_overrides';
 
             $identifiersCondition = new SegmentCondition();
@@ -182,7 +182,7 @@ private static function _mapIdentityOverridesToSegments($identityOverrides)
             foreach (unserialize($serializedOverridesKey) as $overrideKey) {
                 [$featureKey, $featureName, $enabled, $value] = $overrideKey;
                 $feature = new FeatureContext();
-                $feature->key = '--irrelevant--';
+                $feature->key = '';  // Not used in identity overrides
                 $feature->feature_key = $featureKey;
                 $feature->name = $featureName;
                 $feature->enabled = $enabled;
@@ -191,7 +191,8 @@ private static function _mapIdentityOverridesToSegments($identityOverrides)
                 $segment->overrides[] = $feature;
             }
 
-            $segments[$segment->key] = $segment;
+            $segmentKey = hash('sha256', $serializedOverridesKey);
+            $segments[$segmentKey] = $segment;
         }
 
         return $segments;

tests/Utils/MappersTest.php

@@ -47,7 +47,7 @@ public function testMapEnvironmentDocumentToContextProducesEvaluationContext():
 
         $overrideKey = '1dfdec3e4c67121138b1faa01b82f9f731c692842b865f263824bfabf46d5fff';
         $this->assertArrayHasKey($overrideKey, $context->segments);
-        $this->assertEquals($overrideKey, $context->segments[$overrideKey]->key);
+        $this->assertEquals('', $context->segments[$overrideKey]->key);
         $this->assertEquals('identity_overrides', $context->segments[$overrideKey]->name);
         $this->assertCount(1, $context->segments[$overrideKey]->rules);
         $this->assertCount(1, $context->segments[$overrideKey]->overrides);
@@ -60,7 +60,7 @@ public function testMapEnvironmentDocumentToContextProducesEvaluationContext():
         $this->assertEquals(SegmentConditionOperator::IN, $context->segments[$overrideKey]->rules[0]->conditions[0]->operator);
         $this->assertEquals(['overridden-id'], $context->segments[$overrideKey]->rules[0]->conditions[0]->value);
 
-        $this->assertEquals('--irrelevant--', $context->segments[$overrideKey]->overrides[0]->key);
+        $this->assertEquals('', $context->segments[$overrideKey]->overrides[0]->key);
         $this->assertEquals(1, $context->segments[$overrideKey]->overrides[0]->feature_key);
         $this->assertEquals('some_feature', $context->segments[$overrideKey]->overrides[0]->name);
         $this->assertFalse($context->segments[$overrideKey]->overrides[0]->enabled);