You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit updates Flag#from_api to support `false` as a valid value.
Previously, `false` values for `:feature_state_value` would would fall through
the `||` branch and end up using the value from `:value`, which in most (all?)
cases seems to be `nil`.
The previous behavior made it impossible to distinguish between the following
two cases:
- an enabled flag that has never had its value set
(and should therefore be treated as `true`)
- an enabled flag that is explicitly set to `false`
(and should therefore be treated as `false`)
With the change in this commit, the first case will be `nil`, and the second
case would be `false`. The `:value` key will now only be consulted when there
is no `:feature_state_value` key present in the JSON flag data.
0 commit comments