Merge pull request #51 from Flagsmith/fix/make_local_evaluation_multivariate_work

fix: Make local evaluation multivariate work

Author: zachaysan

lib/flagsmith.rb

@@ -209,6 +209,7 @@ def get_identity_flags_from_document(identifier, traits = {})
 
       Flagsmith::Flags::Collection.from_feature_state_models(
         engine.get_identity_feature_states(environment, identity_model),
+        identity_id: identity_model.composite_key,
         analytics_processor: analytics_processor,
         default_flag_handler: default_flag_handler,
         offline_handler: offline_handler

spec/sdk/fixtures/environment.json

@@ -65,6 +65,29 @@
       },
       "segment_id": null,
       "enabled": true
+    },
+    {
+      "feature": {
+        "id": 83755,
+        "name": "test_mv",
+        "type": "MULTIVARIATE"
+      },
+      "enabled": false,
+      "django_id": 482285,
+      "feature_segment": null,
+      "featurestate_uuid": "c3af5fbf-39ba-422c-a846-f2fea952b37c",
+      "feature_state_value": "1111",
+      "multivariate_feature_state_values": [
+        {
+          "multivariate_feature_option": {
+            "value": "8888",
+            "id": 11516
+          },
+          "percentage_allocation": 100.0,
+          "id": 38451,
+          "mv_fs_value_uuid": "a4299c73-2430-47e4-9185-42accd01686c"
+        }
+      ]
     }
   ],
   "updated_at": "2023-07-14 16:12:00.000000",

spec/sdk/local_evaluation_spec.rb

@@ -20,4 +20,18 @@
       expect(flag.value).to eq("some-overridden-value")
     end
   end
+
+  describe '#get_multivariate_flags' do
+    it 'should return a 100% multivariate variation in local evaluation' do
+      allow_any_instance_of(Flagsmith::Client).to receive(:api_client).and_return(mock_api_client)
+
+      flagsmith = Flagsmith::Client.new(environment_key: mock_api_key, api_url: mock_api_url, enable_local_evaluation: true)
+      expect(flagsmith.config.local_evaluation?).to be_truthy
+
+      flag = flagsmith.get_identity_flags("some-identifier").get_flag("test_mv")
+
+      expect(flag.enabled).to be_falsy
+      expect(flag.value).to eq("8888")
+    end
+  end
 end

spec/sdk/offline_mode_spec.rb

@@ -14,7 +14,7 @@
     )
 
     response = flagsmith.get_environment_flags
-    expect(response.count).to eq(1)
+    expect(response.count).to eq(2)
     expect(response.first[-1].feature_name).to eq("some_feature")
   end