feat: introduced-jsonpath-library

Author: Zaimwa9

Gemfile.lock

@@ -4,6 +4,7 @@ PATH
     flagsmith (4.3.0)
       faraday (>= 2.0.1)
       faraday-retry
+      jsonpath (~> 1.1)
       semantic
 
 GEM
@@ -21,8 +22,11 @@ GEM
       faraday (~> 2.0)
     gem-release (2.2.2)
     json (2.7.1)
+    jsonpath (1.1.5)
+      multi_json
     language_server-protocol (3.17.0.3)
     method_source (1.0.0)
+    multi_json (1.17.0)
     net-http (0.4.1)
       uri
     parallel (1.24.0)

flagsmith.gemspec

@@ -34,6 +34,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'faraday', '>= 2.0.1'
   spec.add_dependency 'faraday-retry'
+  spec.add_dependency 'jsonpath', '~> 1.1'
   spec.add_dependency 'semantic'
   spec.metadata['rubygems_mfa_required'] = 'true'
 end

lib/flagsmith/engine/evaluation/core.rb

@@ -122,7 +122,7 @@ def evaluate_feature_value(feature, identity_key = nil)
         # Returns {value: any; reason?: string}
         def get_multivariate_feature_value(feature, identity_key)
           percentage_value = hashed_percentage_for_object_ids([feature[:key], identity_key])
-          sorted_variants = (feature[:variants] || []).sort_by { |v| v[:priority] || Float::INFINITY }
+          sorted_variants = (feature[:variants] || []).sort_by { |v| v[:priority] || WEAKEST_PRIORITY }
 
           start_percentage = 0
           sorted_variants.each do |variant|
@@ -160,7 +160,7 @@ def get_identity_key(evaluation_context)
 
         # returns boolean
         def higher_priority?(priority_a, priority_b)
-          (priority_a || Float::INFINITY) < (priority_b || Float::INFINITY)
+          (priority_a || WEAKEST_PRIORITY) < (priority_b || WEAKEST_PRIORITY)
         end
 
         def get_targeting_match_reason(match_object)

lib/flagsmith/engine/features/models.rb

@@ -58,7 +58,7 @@ def multivariate_value(identity_id)
       #        but `self` does.
       #     2. `other` have a feature segment with high priority
       def higher_segment_priority?(other)
-        feature_segment.priority.to_i < (other&.feature_segment&.priority || Float::INFINITY)
+        feature_segment.priority.to_i < (other&.feature_segment&.priority || WEAKEST_PRIORITY)
       rescue TypeError, NoMethodError
         false
       end

lib/flagsmith/engine/segments/evaluator.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'json'
+require 'jsonpath'
 require_relative 'constants'
 require_relative 'models'
 require_relative '../utils/hash_func'
@@ -31,60 +33,7 @@ def get_identity_segments(context)
           matching_segments
         end
 
-        # Evaluates whether a given identity is in the provided segment.
-        #
-        # :param identity: identity model object to evaluate
-        # :param segment: segment model object to evaluate
-        # :param override_traits: pass in a list of traits to use instead of those on the
-        #     identity model itself
-        # :return: True if the identity is in the segment, False otherwise
-        def evaluate_identity_in_segment(identity, segment, override_traits = nil)
-          segment.rules&.length&.positive? &&
-            segment.rules.all? do |rule|
-              traits_match_segment_rule(
-                override_traits || identity.identity_traits,
-                rule,
-                segment.id,
-                identity.django_id || identity.composite_key
-              )
-            end
-        end
-
-        # rubocop:disable Metrics/MethodLength
-        def traits_match_segment_rule(identity_traits, rule, segment_id, identity_id)
-          matching_block = lambda { |condition|
-            traits_match_segment_condition(identity_traits, condition, segment_id, identity_id)
-          }
-
-          matches_conditions =
-            if rule.conditions&.length&.positive?
-              rule.conditions.send(rule.matching_function, &matching_block)
-            else
-              true
-            end
-
-          matches_conditions &&
-            rule.rules.all? { |r| traits_match_segment_rule(identity_traits, r, segment_id, identity_id) }
-        end
-        # rubocop:enable Metrics/MethodLength
-
-        def traits_match_segment_condition(identity_traits, condition, segment_id, identity_id)
-          if condition.operator == PERCENTAGE_SPLIT
-            return hashed_percentage_for_object_ids([segment_id,
-                                                     identity_id]) <= condition.value.to_f
-          end
-
-          trait = identity_traits.find { |t| t.key.to_s == condition.property }
-
-          return handle_trait_existence_conditions(trait, condition.operator) if [IS_SET,
-                                                                                  IS_NOT_SET].include?(condition.operator)
-
-          return condition.match_trait_value?(trait.trait_value) if trait
-
-          false
-        end
-
-        # Context-based helper functions (new approach)
+        # Context-based helper functions
 
         # Evaluates whether a segment rule matches using context
         #
@@ -143,9 +92,7 @@ def traits_match_segment_condition_from_context(condition, segment_key, context)
           end
 
           return false if condition[:property].nil?
-
           trait_value = get_trait_value(condition[:property], context)
-
           return trait_value != nil if condition[:operator] == IS_SET
           return trait_value.nil? if condition[:operator] == IS_NOT_SET
 
@@ -197,25 +144,15 @@ def get_trait_value(property, context)
           traits[property] || traits[property.to_sym]
         end
 
-        # Get value from context using JSONPath-like syntax
+        # Get value from context using JSONPath syntax
         #
         # @param json_path [String] JSONPath expression (e.g., '$.identity.identifier')
         # @param context [Hash] The evaluation context
         # @return [Object, nil] The value at the path or nil
         def get_context_value(json_path, context)
           return nil unless context && json_path&.start_with?('$.')
-
-          # Simple JSONPath implementation - handle basic cases
-          path_parts = json_path.sub('$.', '').split('.')
-          current = context
-
-          path_parts.each do |part|
-            return nil unless current.is_a?(Hash)
-
-            current = current[part.to_sym]
-          end
-
-          current
+          results = JsonPath.new(json_path, use_symbols: true).on(context)
+          results.first
         rescue StandardError
           nil
         end
@@ -240,14 +177,6 @@ def non_primitive?(value)
 
           value.is_a?(Hash) || value.is_a?(Array)
         end
-
-        private
-
-        def handle_trait_existence_conditions(matching_trait, operator)
-          return operator == IS_NOT_SET if matching_trait.nil?
-
-          operator == IS_SET
-        end
       end
     end
   end

lib/flagsmith/sdk/models/flags.rb

@@ -174,18 +174,6 @@ def from_api(json_data, **args)
           )
         end
 
-        def from_feature_state_models(feature_states, identity_id: nil, **args)
-          to_flag_object = lambda { |feature_state, acc|
-            acc[normalize_key(feature_state.feature.name)] =
-              Flagsmith::Flags::Flag.from_feature_state_model(feature_state, identity_id)
-          }
-
-          new(
-            feature_states.each_with_object({}, &to_flag_object),
-            **args
-          )
-        end
-
         def from_evaluation_result(evaluation_result, **args)
           to_flag_object = lambda { |flag_result, acc|
             flagsmith_id = flag_result.dig(:metadata, :flagsmith_id)