feat: use-overrides-key-hash

Author: Zaimwa9

lib/flagsmith/engine/core.rb

@@ -11,7 +11,7 @@
 require_relative 'segments/evaluator'
 require_relative 'segments/models'
 require_relative 'utils/hash_func'
-require_relative 'evaluationContext/mappers'
+require_relative 'evaluation/mappers'
 
 module Flagsmith
   module Engine

lib/flagsmith/engine/evaluation/mappers.rb

@@ -4,9 +4,8 @@ module Flagsmith
   module Engine
     module EvaluationContext
       module Mappers
-        # Using integer constant instead of -Float::INFINITY because the JSON serializer rejects infinity values
-        HIGHEST_PRIORITY = 0
-        WEAKEST_PRIORITY = 99_999_999
+        STRONGEST_PRIORITY = Float::INFINITY
+        WEAKEST_PRIORITY = -Float::INFINITY
 
         # @param environment [Flagsmith::Engine::Environment] The environment model
         # @param identity [Flagsmith::Engine::Identity, nil] Optional identity model
@@ -165,7 +164,6 @@ def self.map_segment_rule_model_to_rule(rule)
         # @param identity_overrides [Array<Flagsmith::Engine::Identity>] Array of identity override models
         # @return [Hash] Segments hash for identity overrides
         def self.map_identity_overrides_to_segments(identity_overrides)
-          require 'digest'
 
           segments = {}
           features_to_identifiers = {}
@@ -191,7 +189,7 @@ def self.map_identity_overrides_to_segments(identity_overrides)
             end
 
             # Create hash of the overrides to group identities with same overrides
-            overrides_hash = Digest::SHA1.hexdigest(overrides_key.to_json)
+            overrides_hash = overrides_key.hash
 
             features_to_identifiers[overrides_hash] ||= { identifiers: [], overrides: overrides_key }
             features_to_identifiers[overrides_hash][:identifiers] << identity.identifier

spec/engine/unit/evaluation_context_mappers_spec.rb

@@ -72,7 +72,7 @@
       expect(override[:name]).to eq('some_feature')
       expect(override[:enabled]).to be false
       expect(override[:value]).to eq('some-overridden-value')
-      expect(override[:priority]).to eq(Flagsmith::Engine::EvaluationContext::Mappers::WEAKEST_PRIORITY)
+      expect(override[:priority]).to eq(Flagsmith::Engine::EvaluationContext::Mappers::STRONGEST_PRIORITY)
       expect(override[:metadata][:flagsmithId]).to eq(1)
 
       # Verify features