fix: use data instead and add test

Author: existentialcoder

api/.gitignore

@@ -8,3 +8,4 @@ features/workflows/logic/
 
 # Unit test coverage
 .coverage
+.coverage.*

api/app_analytics/views.py

@@ -89,8 +89,8 @@ def get_fields(self):  # type: ignore[no-untyped-def]
             def save(self, **kwargs: typing.Any) -> None:
                 request = self.context["request"]
                 # validated_data splits out request body with '.' in feature name (e.g a.b.c).
-                # Instead, it's safe to use self.initial_data as keys are not altered.
-                for feature_name, evaluation_count in self.initial_data.items():
+                # Instead, it's safe to use self.data as keys are not altered.
+                for feature_name, evaluation_count in self.data.items():
                     feature_evaluation_cache.track_feature_evaluation(
                         environment_id=request.environment.id,
                         feature_name=feature_name,

api/conftest.py

@@ -555,6 +555,10 @@ def api_client() -> APIClient:
 def feature(project: Project) -> Feature:
     return Feature.objects.create(name="Test Feature1", project=project)  # type: ignore[no-any-return]
 
+@pytest.fixture()
+def feauture_with_dots(project: Project) -> Feature:
+    return Feature.objects.create(name="feature.name", project=project)  # type: ignore[no-any-return]
+
 
 @pytest.fixture()
 def change_request(environment: Environment, admin_user: FFAdminUser) -> ChangeRequest:

api/tests/unit/app_analytics/test_unit_app_analytics_views.py

@@ -58,6 +58,38 @@ def test_sdk_analytics_ignores_bad_data(
         labels={},
     )
 
+def test_sdk_analytics_ignores_feature_data_with_dots(
+    mocker: MockerFixture,
+    environment: Environment,
+    feauture_with_dots: Feature,
+    api_client: APIClient,
+) -> None:
+    # Given
+    api_client.credentials(HTTP_X_ENVIRONMENT_KEY=environment.api_key)
+
+    data = { feauture_with_dots.name: 20 }
+    mocked_feature_eval_cache = mocker.patch(
+        "app_analytics.views.feature_evaluation_cache"
+    )
+
+    url = reverse("api-v1:analytics-flags")
+
+    # When
+    response = api_client.post(
+        url, data=json.dumps(data), content_type="application/json"
+    )
+
+    # Then
+    assert response.status_code == status.HTTP_200_OK
+    assert mocked_feature_eval_cache.track_feature_evaluation.call_count == 1
+
+    mocked_feature_eval_cache.track_feature_evaluation.assert_called_once_with(
+        environment_id=environment.id,
+        feature_name=feauture_with_dots.name,
+        evaluation_count=data[feauture_with_dots.name],
+        labels={},
+    )
+
 
 def test_get_usage_data(mocker, admin_client, organisation):  # type: ignore[no-untyped-def]
     # Given