Fix widget configuration issue and crashes

Author: FliegendeWurst

app/src/main/kotlin/eu/fliegendewurst/triliumdroid/database/Cache.kt

@@ -315,8 +315,8 @@ object Cache {
 			while (it.moveToNext()) {
 				val id = NoteId(it.getString(0))
 				val title = it.getString(1)
-				val attrName = it.getString(2)
-				val attrValue = it.getString(3)
+				val attrName = it.getStringOrNull(2)
+				val attrValue = it.getStringOrNull(3)
 				val attrIdRaw = it.getStringOrNull(4)
 				val attrId = if (attrIdRaw != null) {
 					AttributeId(attrIdRaw)
@@ -342,8 +342,9 @@ object Cache {
 						BlobId("INVALID")
 					)
 				}
-				if (attrValue != null && !attrValue.startsWith('_') &&
-					!attrName.startsWith("child:") && attrId != null
+				if (attrId != null && attrName != null && attrValue != null &&
+					!attrValue.startsWith('_') &&
+					!attrName.startsWith("child:")
 				) {
 					relations.add(Triple(id, NoteId(attrValue), Pair(attrName, attrId)))
 				}

app/src/main/kotlin/eu/fliegendewurst/triliumdroid/database/CacheDbHelper.kt

@@ -14,6 +14,7 @@ class CacheDbHelper(context: Context, private val sql: String) :
 	SQLiteOpenHelper(context, Versions.DATABASE_NAME, null, Versions.DATABASE_VERSION) {
 	companion object {
 		private const val TAG = "CacheDbHelper"
+		const val MAX_MIGRATION = 2
 	}
 
 	override fun onCreate(db: SQLiteDatabase) {
@@ -40,7 +41,7 @@ class CacheDbHelper(context: Context, private val sql: String) :
 				}
 			}
 			// DB migrations are only for fixups
-			Preferences.setDatabaseMigration(2)
+			Preferences.setDatabaseMigration(MAX_MIGRATION)
 		} catch (t: Throwable) {
 			Log.e(TAG, "fatal error creating database", t)
 		}

app/src/main/kotlin/eu/fliegendewurst/triliumdroid/database/DB.kt

@@ -4,6 +4,7 @@ import android.content.ContentValues
 import android.content.Context
 import android.database.AbstractWindowedCursor
 import android.database.Cursor
+import android.database.Cursor.FIELD_TYPE_STRING
 import android.database.CursorWindow
 import android.database.sqlite.SQLiteCursorDriver
 import android.database.sqlite.SQLiteDatabase
@@ -13,6 +14,7 @@ import android.util.Log
 import androidx.core.database.getStringOrNull
 import eu.fliegendewurst.triliumdroid.R
 import eu.fliegendewurst.triliumdroid.database.Branches.branches
+import eu.fliegendewurst.triliumdroid.database.CacheDbHelper.Companion.MAX_MIGRATION
 import eu.fliegendewurst.triliumdroid.database.Notes.notes
 import eu.fliegendewurst.triliumdroid.util.Preferences
 import eu.fliegendewurst.triliumdroid.util.Unreachable
@@ -188,6 +190,9 @@ object DB {
 			).use {
 				while (it.moveToNext()) {
 					val id = it.getString(0)
+					if (it.getType(1) != FIELD_TYPE_STRING) {
+						continue
+					}
 					val content = it.getStringOrNull(1)
 					if (content != null) {
 						decoded.add(Pair(id, Base64.decode(content)))
@@ -203,7 +208,7 @@ object DB {
 		if (migrationLevel < 2) {
 			Blobs.fixupBrokenBlobIDs()
 		}
-		Preferences.setDatabaseMigration(2)
+		Preferences.setDatabaseMigration(MAX_MIGRATION)
 	}
 
 	fun nukeDatabase(context: Context) {
@@ -219,7 +224,7 @@ object DB {
 		branches.clear()
 		lastSync = null
 		// DB migrations are only for fixups
-		Preferences.setDatabaseMigration(2)
+		Preferences.setDatabaseMigration(MAX_MIGRATION)
 	}
 
 	fun closeDatabase() {

app/src/main/kotlin/eu/fliegendewurst/triliumdroid/util/Preferences.kt

@@ -7,6 +7,7 @@ import androidx.preference.PreferenceManager
 import eu.fliegendewurst.triliumdroid.activity.main.HistoryItem
 import eu.fliegendewurst.triliumdroid.data.CanvasNoteViewport
 import eu.fliegendewurst.triliumdroid.data.NoteId
+import eu.fliegendewurst.triliumdroid.database.CacheDbHelper.Companion.MAX_MIGRATION
 import eu.fliegendewurst.triliumdroid.service.Util
 import eu.fliegendewurst.triliumdroid.widget.parseWidgetAction
 
@@ -33,6 +34,12 @@ object Preferences {
 
 	fun init(applicationContext: Context) {
 		prefs = PreferenceManager.getDefaultSharedPreferences(applicationContext)
+		if (!prefs.contains(DATABASE_VERSION) && !prefs.contains(HOSTNAME)) {
+			// This is relevant if the app is uninstalled and reinstalled,
+			// in which case the database may persist. We assume it doesn't
+			// need fixups in that case.
+			setDatabaseMigration(MAX_MIGRATION)
+		}
 	}
 
 	fun hostname(): String? = prefs.getString(HOSTNAME, null)

app/src/main/kotlin/eu/fliegendewurst/triliumdroid/widget/NoteWidget.kt

@@ -48,6 +48,7 @@ class NoteWidget : AppWidgetProvider() {
 		appWidgetIds: IntArray
 	) {
 		Preferences.init(context.applicationContext)
+		DB.applicationContext = context.applicationContext
 		if (DB.haveDatabase(context)) {
 			runBlocking {
 				// There may be multiple widgets active, so update all of them
@@ -65,6 +66,7 @@ class NoteWidget : AppWidgetProvider() {
 		newOptions: Bundle?
 	) {
 		Preferences.init(context.applicationContext)
+		DB.applicationContext = context.applicationContext
 		if (DB.haveDatabase(context)) {
 			runBlocking {
 				updateAppWidget(context, appWidgetManager, appWidgetId, newOptions)
@@ -74,6 +76,7 @@ class NoteWidget : AppWidgetProvider() {
 
 	override fun onEnabled(context: Context) {
 		Preferences.init(context.applicationContext)
+		DB.applicationContext = context.applicationContext
 		if (DB.haveDatabase(context)) {
 			runBlocking {
 				DB.initializeDatabase(context)

fastlane/metadata/android/en-US/changelogs/15.txt

@@ -0,0 +1,3 @@
+Bugfixes
+- Fix many bugs/crashes with widgets
+- Fixed crash when re-installing the app without deleting app data