Skip to content

Commit b11fc9a

Browse files
Make setup.py PyPI-compatible by separating git dependencies (ROCm#1653)
* trying to fix pypi won't handle git dependencies * fix format * fix comments typo
1 parent e467f7d commit b11fc9a

3 files changed

Lines changed: 15 additions & 16 deletions

File tree

README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ If you happen to forget the `--recursive` during `clone`, you can use the follow
2525
git submodule sync && git submodule update --init --recursive
2626
```
2727

28+
2829
### Triton-based Communication (Iris)
2930

3031
AITER supports GPU-initiated communication using the [Iris library](https://github.com/ROCm/iris). This enables high-performance Triton-based communication primitives like reduce-scatter and all-gather.
@@ -34,12 +35,10 @@ AITER supports GPU-initiated communication using the [Iris library](https://gith
3435
Install with Triton communication support:
3536

3637
```bash
37-
# Option 1: Install via extras
38-
pip install -e ".[triton_comms]"
39-
40-
# Option 2: Install all optional dependencies
41-
pip install -e ".[all]"
42-
```
38+
# Install AITER with Triton communication dependencies
39+
pip install -e .
40+
pip install -r requirements-triton-comms.txt
41+
```
4342

4443
For more details, see [docs/triton_comms.md](docs/triton_comms.md).
4544

requirements-triton-comms.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Optional dependencies for Triton-based GPU communication
2+
# Iris library for GPU-initiated communication primitives
3+
# Pinned to commit 905ec1c (Nov 18, 2024) for reproducibility and API stability
4+
iris @ git+https://github.com/ROCm/iris.git@905ec1cea8f350211a70c7d0b2bc11a09a6f6429
5+

setup.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -307,9 +307,6 @@ def has_ext_modules(self):
307307
return True
308308

309309

310-
# Define Iris dependency once to avoid duplication
311-
IRIS_DEP = "iris @ git+https://github.com/ROCm/iris.git@905ec1cea8f350211a70c7d0b2bc11a09a6f6429"
312-
313310
setup(
314311
name=PACKAGE_NAME,
315312
use_scm_version=True,
@@ -334,14 +331,12 @@ def has_ext_modules(self):
334331
],
335332
extras_require={
336333
# Triton-based communication using Iris
337-
# Pinned to commit 905ec1c (Nov 18, 2024) for reproducibility and API stability
338-
"triton_comms": [
339-
IRIS_DEP,
340-
],
334+
# Note: Iris is not available on PyPI and must be installed separately
335+
# Install with: pip install -r requirements-triton-comms.txt
336+
# (See requirements-triton-comms.txt for pinned Iris version)
337+
"triton_comms": [],
341338
# Install all optional dependencies
342-
"all": [
343-
IRIS_DEP,
344-
],
339+
"all": [],
345340
},
346341
setup_requires=setup_requires,
347342
distclass=ForcePlatlibDistribution,

0 commit comments

Comments
 (0)