Rename PUBLIC_DISABLE_SIGNUP to PUBLIC_ENABLE_SIGNUP

[erikvanoosten]

This is a small feature request.

The env variable PUBLIC_DISABLE_SIGNUP leads to double negatives. This can be solved by renaming it to PUBLIC_ENABLE_SIGNUP.

[Flomp]

Can you specify how this leads to double negatives? The wording is based on the default that is sensible for most instances: signup is enabled and has to be explicitly disabled via this env var.

[erikvanoosten]

Thanks for following-up. For example, PUBLIC_DISABLE_SIGNUP = false is a double negative. I understand from you that this is the default, but that doesn't matter, I still need to do mental gymnastics to understand it because I want to know what I am deploying on my hardware.

[mattague]

Maybe changing the variable name to PUBLIC_SIGNUP with a default of true/enabled would be a better phrasing?