fix(action): fix shutdown hang, switch back to download binary

Author: FlorentinoJink

action/action.yml

@@ -218,28 +218,29 @@ runs:
 
         Write-Host "::endgroup::"
 
-    # ── Step 3: Build mcp-windbg-rs from source ─────────────────────────
-    - name: Build MCP Server
-      id: build-server
+    # ── Step 3: Download mcp-windbg-rs binary ─────────────────────────────
+    - name: Download MCP Server
+      id: download-server
       if: env.SKIP_ANALYSIS != 'true'
       shell: pwsh
       run: |
-        Write-Host "::group::Step 3 - Build mcp-windbg-rs from source"
+        Write-Host "::group::Step 3 - Download mcp-windbg-rs"
 
-        $env:RUSTFLAGS = "-C target-feature=+crt-static"
-        cargo build --release 2>&1 | ForEach-Object { Write-Host $_ }
-        if ($LASTEXITCODE -ne 0) {
-          Write-Host "::error::Failed to build mcp-windbg-rs"
-          exit 1
-        }
+        $repo = "FlorentinoJink/mcp-windbg"
+        $apiUrl = "https://api.github.com/repos/$repo/releases/latest"
 
-        $serverPath = Join-Path $env:GITHUB_WORKSPACE "target\release\mcp-windbg-rs.exe"
-        if (-not (Test-Path $serverPath)) {
-          Write-Host "::error::Binary not found at $serverPath"
+        $release = Invoke-RestMethod -Uri $apiUrl -Headers @{ "User-Agent" = "mcp-windbg-action" }
+        $asset = $release.assets | Where-Object { $_.name -like '*.exe' } | Select-Object -First 1
+        if (-not $asset) {
+          Write-Host "::error::No .exe asset in release $($release.tag_name)"
           exit 1
         }
 
-        Write-Host "Built: $serverPath ($((Get-Item $serverPath).Length) bytes)"
+        $serverPath = Join-Path $env:GITHUB_WORKSPACE "mcp-windbg-rs.exe"
+        Write-Host "Downloading $($asset.name) ..."
+        Invoke-WebRequest -Uri $asset.browser_download_url -OutFile $serverPath -UseBasicParsing
+
+        Write-Host "Downloaded: $serverPath ($((Get-Item $serverPath).Length) bytes)"
         echo "MCP_SERVER_PATH=$serverPath" >> $env:GITHUB_ENV
         Write-Host "::endgroup::"
 

action/mcp_client.py

@@ -200,24 +200,20 @@ def shutdown(self):
         if self._proc is None:
             return
         log("Shutting down MCP server...")
-        # Capture stderr for debugging
-        try:
-            stderr_data = self._proc.stderr.read().decode("utf-8", errors="replace")
-            if stderr_data.strip():
-                log(f"MCP server stderr:\n{stderr_data[:2000]}")
-        except Exception:
-            pass
         try:
             self._proc.stdin.close()
         except Exception:
             pass
         try:
-            self._proc.wait(timeout=10)
+            self._proc.wait(timeout=5)
             log(f"MCP server exited (code={self._proc.returncode}).")
         except subprocess.TimeoutExpired:
-            log("MCP server did not exit in time, killing...")
+            log("MCP server did not exit in 5s, killing...")
             self._proc.kill()
-            self._proc.wait(timeout=5)
+            try:
+                self._proc.wait(timeout=3)
+            except Exception:
+                pass
             log("MCP server killed.")
 
     # -- low-level transport -------------------------------------------------