|
1 | 1 | package org.flossware.filetransfer; |
2 | 2 |
|
| 3 | +import com.github.sardine.DavResource; |
| 4 | +import com.github.sardine.Sardine; |
| 5 | +import com.github.sardine.SardineFactory; |
3 | 6 | import org.junit.jupiter.api.AfterEach; |
4 | 7 | import org.junit.jupiter.api.Test; |
5 | 8 | import org.junit.jupiter.api.DisplayName; |
| 9 | +import org.mockito.MockedStatic; |
6 | 10 |
|
| 11 | +import java.io.ByteArrayInputStream; |
| 12 | +import java.io.IOException; |
| 13 | +import java.io.InputStream; |
7 | 14 | import java.lang.reflect.Method; |
| 15 | +import java.util.ArrayList; |
| 16 | +import java.util.Collections; |
| 17 | +import java.util.List; |
8 | 18 |
|
9 | 19 | import static org.junit.jupiter.api.Assertions.*; |
| 20 | +import static org.mockito.ArgumentMatchers.*; |
| 21 | +import static org.mockito.Mockito.*; |
10 | 22 |
|
11 | 23 | /** |
12 | 24 | * Comprehensive tests for WebDavFileTransferClient to achieve 100% coverage. |
@@ -303,6 +315,344 @@ void testEmptyStringCredentials() { |
303 | 315 | assertTrue(description.contains("authenticated=true")); |
304 | 316 | } |
305 | 317 |
|
| 318 | + // Tests for actual WebDAV operations using mocked Sardine |
| 319 | + |
| 320 | + @Test |
| 321 | + @DisplayName("Should read file successfully") |
| 322 | + void testReadFileSuccess() throws Exception { |
| 323 | + byte[] fileContent = "test file content".getBytes(); |
| 324 | + ByteArrayInputStream inputStream = new ByteArrayInputStream(fileContent); |
| 325 | + |
| 326 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 327 | + Sardine sardine = mock(Sardine.class); |
| 328 | + factoryMock.when(() -> SardineFactory.begin(anyString(), anyString())).thenReturn(sardine); |
| 329 | + when(sardine.get(anyString())).thenReturn(inputStream); |
| 330 | + |
| 331 | + client = WebDavFileTransferClient.builder() |
| 332 | + .baseUrl("https://webdav.example.com/files/") |
| 333 | + .username("user") |
| 334 | + .password("pass") |
| 335 | + .build(); |
| 336 | + |
| 337 | + byte[] result = client.readFile("test.txt"); |
| 338 | + assertArrayEquals(fileContent, result); |
| 339 | + verify(sardine).get("https://webdav.example.com/files/test.txt"); |
| 340 | + } |
| 341 | + } |
| 342 | + |
| 343 | + @Test |
| 344 | + @DisplayName("Should throw IOException when readFile fails") |
| 345 | + void testReadFileFailure() throws Exception { |
| 346 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 347 | + Sardine sardine = mock(Sardine.class); |
| 348 | + factoryMock.when(() -> SardineFactory.begin(anyString(), anyString())).thenReturn(sardine); |
| 349 | + when(sardine.get(anyString())).thenThrow(new IOException("File not found")); |
| 350 | + |
| 351 | + client = WebDavFileTransferClient.builder() |
| 352 | + .baseUrl("https://webdav.example.com/") |
| 353 | + .username("user") |
| 354 | + .password("pass") |
| 355 | + .build(); |
| 356 | + |
| 357 | + IOException thrown = assertThrows(IOException.class, () -> client.readFile("missing.txt")); |
| 358 | + assertTrue(thrown.getMessage().contains("File not found")); |
| 359 | + } |
| 360 | + } |
| 361 | + |
| 362 | + @Test |
| 363 | + @DisplayName("Should open file successfully") |
| 364 | + void testOpenFileSuccess() throws Exception { |
| 365 | + ByteArrayInputStream inputStream = new ByteArrayInputStream("test".getBytes()); |
| 366 | + |
| 367 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 368 | + Sardine sardine = mock(Sardine.class); |
| 369 | + factoryMock.when(() -> SardineFactory.begin(anyString(), anyString())).thenReturn(sardine); |
| 370 | + when(sardine.get(anyString())).thenReturn(inputStream); |
| 371 | + |
| 372 | + client = WebDavFileTransferClient.builder() |
| 373 | + .baseUrl("https://webdav.example.com/files/") |
| 374 | + .username("user") |
| 375 | + .password("pass") |
| 376 | + .build(); |
| 377 | + |
| 378 | + InputStream result = client.openFile("test.txt"); |
| 379 | + assertSame(inputStream, result); |
| 380 | + } |
| 381 | + } |
| 382 | + |
| 383 | + @Test |
| 384 | + @DisplayName("Should throw IOException when openFile fails") |
| 385 | + void testOpenFileFailure() throws Exception { |
| 386 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 387 | + Sardine sardine = mock(Sardine.class); |
| 388 | + factoryMock.when(() -> SardineFactory.begin()).thenReturn(sardine); |
| 389 | + when(sardine.get(anyString())).thenThrow(new IOException("Cannot open file")); |
| 390 | + |
| 391 | + client = WebDavFileTransferClient.builder() |
| 392 | + .baseUrl("https://webdav.example.com/") |
| 393 | + .build(); |
| 394 | + |
| 395 | + IOException thrown = assertThrows(IOException.class, () -> client.openFile("test.txt")); |
| 396 | + assertTrue(thrown.getMessage().contains("Cannot open file")); |
| 397 | + } |
| 398 | + } |
| 399 | + |
| 400 | + @Test |
| 401 | + @DisplayName("Should return true when file exists") |
| 402 | + void testExistsTrue() throws Exception { |
| 403 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 404 | + Sardine sardine = mock(Sardine.class); |
| 405 | + factoryMock.when(() -> SardineFactory.begin()).thenReturn(sardine); |
| 406 | + when(sardine.exists(anyString())).thenReturn(true); |
| 407 | + |
| 408 | + client = WebDavFileTransferClient.builder() |
| 409 | + .baseUrl("https://webdav.example.com/") |
| 410 | + .build(); |
| 411 | + |
| 412 | + assertTrue(client.exists("test.txt")); |
| 413 | + verify(sardine).exists("https://webdav.example.com/test.txt"); |
| 414 | + } |
| 415 | + } |
| 416 | + |
| 417 | + @Test |
| 418 | + @DisplayName("Should return false when file does not exist") |
| 419 | + void testExistsFalse() throws Exception { |
| 420 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 421 | + Sardine sardine = mock(Sardine.class); |
| 422 | + factoryMock.when(() -> SardineFactory.begin(anyString(), anyString())).thenReturn(sardine); |
| 423 | + when(sardine.exists(anyString())).thenReturn(false); |
| 424 | + |
| 425 | + client = WebDavFileTransferClient.builder() |
| 426 | + .baseUrl("https://webdav.example.com/files/") |
| 427 | + .username("user") |
| 428 | + .password("pass") |
| 429 | + .build(); |
| 430 | + |
| 431 | + assertFalse(client.exists("missing.txt")); |
| 432 | + } |
| 433 | + } |
| 434 | + |
| 435 | + @Test |
| 436 | + @DisplayName("Should list files successfully") |
| 437 | + void testListSuccess() throws Exception { |
| 438 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 439 | + Sardine sardine = mock(Sardine.class); |
| 440 | + factoryMock.when(() -> SardineFactory.begin()).thenReturn(sardine); |
| 441 | + |
| 442 | + DavResource dir = mock(DavResource.class); |
| 443 | + DavResource file1 = mock(DavResource.class); |
| 444 | + DavResource file2 = mock(DavResource.class); |
| 445 | + |
| 446 | + when(dir.getPath()).thenReturn("uploads/"); |
| 447 | + when(file1.getPath()).thenReturn("/uploads/file1.txt"); |
| 448 | + when(file2.getPath()).thenReturn("/uploads/file2.txt"); |
| 449 | + |
| 450 | + List<DavResource> resources = new ArrayList<>(); |
| 451 | + resources.add(dir); |
| 452 | + resources.add(file1); |
| 453 | + resources.add(file2); |
| 454 | + |
| 455 | + when(sardine.list(anyString())).thenReturn(resources); |
| 456 | + |
| 457 | + client = WebDavFileTransferClient.builder() |
| 458 | + .baseUrl("https://webdav.example.com/") |
| 459 | + .build(); |
| 460 | + |
| 461 | + List<String> result = client.list("uploads/"); |
| 462 | + assertEquals(2, result.size()); |
| 463 | + assertTrue(result.contains("uploads/file1.txt")); |
| 464 | + assertTrue(result.contains("uploads/file2.txt")); |
| 465 | + } |
| 466 | + } |
| 467 | + |
| 468 | + @Test |
| 469 | + @DisplayName("Should filter directory itself from list results") |
| 470 | + void testListFilterDirectory() throws Exception { |
| 471 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 472 | + Sardine sardine = mock(Sardine.class); |
| 473 | + factoryMock.when(() -> SardineFactory.begin(anyString(), anyString())).thenReturn(sardine); |
| 474 | + |
| 475 | + DavResource dir = mock(DavResource.class); |
| 476 | + when(dir.getPath()).thenReturn("docs"); |
| 477 | + |
| 478 | + List<DavResource> resources = Collections.singletonList(dir); |
| 479 | + when(sardine.list(anyString())).thenReturn(resources); |
| 480 | + |
| 481 | + client = WebDavFileTransferClient.builder() |
| 482 | + .baseUrl("https://webdav.example.com/") |
| 483 | + .username("user") |
| 484 | + .password("pass") |
| 485 | + .build(); |
| 486 | + |
| 487 | + List<String> result = client.list("docs"); |
| 488 | + assertTrue(result.isEmpty()); |
| 489 | + } |
| 490 | + } |
| 491 | + |
| 492 | + @Test |
| 493 | + @DisplayName("Should handle paths without leading slash") |
| 494 | + void testListPathNormalization() throws Exception { |
| 495 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 496 | + Sardine sardine = mock(Sardine.class); |
| 497 | + factoryMock.when(() -> SardineFactory.begin()).thenReturn(sardine); |
| 498 | + |
| 499 | + DavResource file = mock(DavResource.class); |
| 500 | + when(file.getPath()).thenReturn("uploads/file.txt"); |
| 501 | + |
| 502 | + List<DavResource> resources = Collections.singletonList(file); |
| 503 | + when(sardine.list(anyString())).thenReturn(resources); |
| 504 | + |
| 505 | + client = WebDavFileTransferClient.builder() |
| 506 | + .baseUrl("https://webdav.example.com/") |
| 507 | + .build(); |
| 508 | + |
| 509 | + List<String> result = client.list("uploads"); |
| 510 | + assertEquals(1, result.size()); |
| 511 | + assertEquals("uploads/file.txt", result.get(0)); |
| 512 | + } |
| 513 | + } |
| 514 | + |
| 515 | + @Test |
| 516 | + @DisplayName("Should throw IOException when list fails") |
| 517 | + void testListFailure() throws Exception { |
| 518 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 519 | + Sardine sardine = mock(Sardine.class); |
| 520 | + factoryMock.when(() -> SardineFactory.begin()).thenReturn(sardine); |
| 521 | + when(sardine.list(anyString())).thenThrow(new IOException("Directory not found")); |
| 522 | + |
| 523 | + client = WebDavFileTransferClient.builder() |
| 524 | + .baseUrl("https://webdav.example.com/") |
| 525 | + .build(); |
| 526 | + |
| 527 | + IOException thrown = assertThrows(IOException.class, () -> client.list("missing")); |
| 528 | + assertTrue(thrown.getMessage().contains("Directory not found")); |
| 529 | + } |
| 530 | + } |
| 531 | + |
| 532 | + @Test |
| 533 | + @DisplayName("Should get file size successfully") |
| 534 | + void testGetFileSizeSuccess() throws Exception { |
| 535 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 536 | + Sardine sardine = mock(Sardine.class); |
| 537 | + factoryMock.when(() -> SardineFactory.begin(anyString(), anyString())).thenReturn(sardine); |
| 538 | + |
| 539 | + DavResource resource = mock(DavResource.class); |
| 540 | + when(resource.isDirectory()).thenReturn(false); |
| 541 | + when(resource.getContentLength()).thenReturn(12345L); |
| 542 | + |
| 543 | + List<DavResource> resources = Collections.singletonList(resource); |
| 544 | + when(sardine.list(anyString())).thenReturn(resources); |
| 545 | + |
| 546 | + client = WebDavFileTransferClient.builder() |
| 547 | + .baseUrl("https://webdav.example.com/") |
| 548 | + .username("user") |
| 549 | + .password("pass") |
| 550 | + .build(); |
| 551 | + |
| 552 | + assertEquals(12345L, client.getFileSize("test.txt")); |
| 553 | + } |
| 554 | + } |
| 555 | + |
| 556 | + @Test |
| 557 | + @DisplayName("Should throw IOException when file not found for size") |
| 558 | + void testGetFileSizeNotFound() throws Exception { |
| 559 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 560 | + Sardine sardine = mock(Sardine.class); |
| 561 | + factoryMock.when(() -> SardineFactory.begin()).thenReturn(sardine); |
| 562 | + when(sardine.list(anyString())).thenReturn(Collections.emptyList()); |
| 563 | + |
| 564 | + client = WebDavFileTransferClient.builder() |
| 565 | + .baseUrl("https://webdav.example.com/") |
| 566 | + .build(); |
| 567 | + |
| 568 | + IOException thrown = assertThrows(IOException.class, () -> client.getFileSize("missing.txt")); |
| 569 | + assertTrue(thrown.getMessage().contains("File not found")); |
| 570 | + } |
| 571 | + } |
| 572 | + |
| 573 | + @Test |
| 574 | + @DisplayName("Should throw IOException when getting size of directory") |
| 575 | + void testGetFileSizeDirectory() throws Exception { |
| 576 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 577 | + Sardine sardine = mock(Sardine.class); |
| 578 | + factoryMock.when(() -> SardineFactory.begin()).thenReturn(sardine); |
| 579 | + |
| 580 | + DavResource resource = mock(DavResource.class); |
| 581 | + when(resource.isDirectory()).thenReturn(true); |
| 582 | + |
| 583 | + List<DavResource> resources = Collections.singletonList(resource); |
| 584 | + when(sardine.list(anyString())).thenReturn(resources); |
| 585 | + |
| 586 | + client = WebDavFileTransferClient.builder() |
| 587 | + .baseUrl("https://webdav.example.com/") |
| 588 | + .build(); |
| 589 | + |
| 590 | + IOException thrown = assertThrows(IOException.class, () -> client.getFileSize("directory")); |
| 591 | + assertTrue(thrown.getMessage().contains("Path is a directory")); |
| 592 | + } |
| 593 | + } |
| 594 | + |
| 595 | + @Test |
| 596 | + @DisplayName("Should return 0 when content length is null") |
| 597 | + void testGetFileSizeNullContentLength() throws Exception { |
| 598 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 599 | + Sardine sardine = mock(Sardine.class); |
| 600 | + factoryMock.when(() -> SardineFactory.begin(anyString(), anyString())).thenReturn(sardine); |
| 601 | + |
| 602 | + DavResource resource = mock(DavResource.class); |
| 603 | + when(resource.isDirectory()).thenReturn(false); |
| 604 | + when(resource.getContentLength()).thenReturn(null); |
| 605 | + |
| 606 | + List<DavResource> resources = Collections.singletonList(resource); |
| 607 | + when(sardine.list(anyString())).thenReturn(resources); |
| 608 | + |
| 609 | + client = WebDavFileTransferClient.builder() |
| 610 | + .baseUrl("https://webdav.example.com/") |
| 611 | + .username("user") |
| 612 | + .password("pass") |
| 613 | + .build(); |
| 614 | + |
| 615 | + assertEquals(0L, client.getFileSize("test.txt")); |
| 616 | + } |
| 617 | + } |
| 618 | + |
| 619 | + @Test |
| 620 | + @DisplayName("Should close and shutdown Sardine") |
| 621 | + void testClose() throws Exception { |
| 622 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 623 | + Sardine sardine = mock(Sardine.class); |
| 624 | + factoryMock.when(() -> SardineFactory.begin()).thenReturn(sardine); |
| 625 | + doNothing().when(sardine).shutdown(); |
| 626 | + |
| 627 | + client = WebDavFileTransferClient.builder() |
| 628 | + .baseUrl("https://webdav.example.com/") |
| 629 | + .build(); |
| 630 | + |
| 631 | + client.close(); |
| 632 | + |
| 633 | + verify(sardine).shutdown(); |
| 634 | + } |
| 635 | + } |
| 636 | + |
| 637 | + @Test |
| 638 | + @DisplayName("Should propagate IOException from shutdown") |
| 639 | + void testCloseError() throws Exception { |
| 640 | + try (MockedStatic<SardineFactory> factoryMock = mockStatic(SardineFactory.class)) { |
| 641 | + Sardine sardine = mock(Sardine.class); |
| 642 | + factoryMock.when(() -> SardineFactory.begin(anyString(), anyString())).thenReturn(sardine); |
| 643 | + doThrow(new IOException("Shutdown failed")).when(sardine).shutdown(); |
| 644 | + |
| 645 | + client = WebDavFileTransferClient.builder() |
| 646 | + .baseUrl("https://webdav.example.com/") |
| 647 | + .username("user") |
| 648 | + .password("pass") |
| 649 | + .build(); |
| 650 | + |
| 651 | + IOException thrown = assertThrows(IOException.class, () -> client.close()); |
| 652 | + assertTrue(thrown.getMessage().contains("Shutdown failed")); |
| 653 | + } |
| 654 | + } |
| 655 | + |
306 | 656 | private WebDavFileTransferClient createTestClient(String baseUrl, String username, String password) throws Exception { |
307 | 657 | java.lang.reflect.Constructor<WebDavFileTransferClient> constructor = |
308 | 658 | WebDavFileTransferClient.class.getDeclaredConstructor( |
|
0 commit comments