-
Notifications
You must be signed in to change notification settings - Fork 158
Add Jira search plugin #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The
Websiteof your plugin'splugin.jsonfile should lead to your plugin's website, not Jira's website. In your case, you probably wanthttps://github.com/haugjan/Flow.JiraSearch. - The
Disabledkey is not one that you should be providing in your plugin'splugin.jsonfile.
| @@ -0,0 +1,12 @@ | |||
| { | |||
| "ID": "BD32A62C-6F98-4541-AE8E-17B46458595F", | |||
| "Name": "JiraSearch", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name here does not match the name in your plugin's plugin.json file.
| "Name": "JiraSearch", | |
| "Name": "Jira Search", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the very quick review. I really appreciate it.
I have implemented all the changes in my repo and here. So: Back to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me, however I didn't preform a manual integration test
|
Hi @cibere , I'm not sure how to proceed here. Am I correct in assuming that someone else needs to merge this? I can't do it myself. Right? |
A plugin to search in Atlassian Jira