Skip to content

Commit e55f79e

Browse files
committed
Improve code comments & code quality
1 parent d08deab commit e55f79e

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

Diff for: Flow.Launcher.Core/ExternalPlugins/Environments/PythonEnvironment.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ internal override void InstallEnvironment()
3939

4040
// Python 3.11.4 is no longer Windows 7 compatible. If user is on Win 7 and
4141
// uses Python plugin they need to custom install and use v3.8.9
42-
JTF.Run(async () => await DroplexPackage.Drop(App.python_3_11_4_embeddable, InstallPath));
42+
JTF.Run(() => DroplexPackage.Drop(App.python_3_11_4_embeddable, InstallPath));
4343

4444
PluginsSettingsFilePath = ExecutablePath;
4545
}

Diff for: Flow.Launcher.Core/ExternalPlugins/Environments/TypeScriptEnvironment.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ internal override void InstallEnvironment()
3434
{
3535
FilesFolders.RemoveFolderIfExists(InstallPath, (s) => API.ShowMsgBox(s));
3636

37-
JTF.Run(async () => await DroplexPackage.Drop(App.nodejs_16_18_0, InstallPath));
37+
JTF.Run(() => DroplexPackage.Drop(App.nodejs_16_18_0, InstallPath));
3838

3939
PluginsSettingsFilePath = ExecutablePath;
4040
}

Diff for: Flow.Launcher.Core/ExternalPlugins/Environments/TypeScriptV2Environment.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ internal override void InstallEnvironment()
3434
{
3535
FilesFolders.RemoveFolderIfExists(InstallPath, (s) => API.ShowMsgBox(s));
3636

37-
JTF.Run(async () => await DroplexPackage.Drop(App.nodejs_16_18_0, InstallPath));
37+
JTF.Run(() => DroplexPackage.Drop(App.nodejs_16_18_0, InstallPath));
3838

3939
PluginsSettingsFilePath = ExecutablePath;
4040
}

Diff for: Flow.Launcher/App.xaml.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ private static void RegisterAppDomainExceptions()
289289
}
290290

291291
/// <summary>
292-
/// exception will not be thrown normally, so we need to register event
292+
/// let exception throw as normal for Debug and Release
293293
/// </summary>
294294
private static void RegisterTaskSchedulerUnhandledException()
295295
{

Diff for: Flow.Launcher/ViewModel/MainViewModel.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1347,7 +1347,7 @@ private Query ConstructQuery(string queryText, IEnumerable<CustomShortcutModel>
13471347
}
13481348
else if (shortcut is AsyncBuiltinShortcutModel asyncShortcut)
13491349
{
1350-
expansion = App.JTF.Run(async () => await asyncShortcut.ExpandAsync());
1350+
expansion = App.JTF.Run(() => asyncShortcut.ExpandAsync());
13511351
}
13521352
else
13531353
{

0 commit comments

Comments
 (0)