BUG: WinGet release uploads with the wrong hash

[jjw24]

Checks

• I have checked that this issue has not already been reported.

• I am using the latest version of Flow Launcher.

Problem Description

WinGet release uploads with the wrong hash, most likely due to dual release steps in the appveyor.yml on merge to master.

microsoft/winget-pkgs#103060 (comment)

To Reproduce

1. ...
2. ...
3. ...

Screenshots

No response

Flow Launcher Version

0

Windows Build Number

0

Error Log

Replace this line with the important log contents.

[JohnTheGr8]

is this related to the Publish to Winget action firing twice per release?

[jjw24]

Yes.

We probably can remove the first upload and keep the upload from tagging.

[JohnTheGr8]

We probably can remove the first upload and keep the upload from tagging.

hmm, but the first upload should be marked as draft, which shouldn't trigger the winget workflow... right?

the workflow defines the condition:

on:
  release:
    types: [released]

[JohnTheGr8]

I agree though, we can try that, see how it works.

How about we modify the appveyor deployment config so that commits to master create a RC release on the Prereleases repo, instead of a draft release on the main repo?

[Garulf]

We probably can remove the first upload and keep the upload from tagging.

hmm, but the first upload should be marked as draft, which shouldn't trigger the winget workflow... right?

the workflow defines the condition:

on:

  release:

    types: [released]

The documentation doesn't clearly say as far as I can tell. 🤔

[JohnTheGr8]

The documentation doesn't clearly say as far as I can tell. 🤔

yup, I find it vague as well...

How about we modify the appveyor deployment config so that commits to master create a RC release on the Prereleases repo, instead of a draft release on the main repo?

I mean something like:

   - provider: GitHub
+    repository: Flow-Launcher/Prereleases
     release: v$(flowVersion)
+    description: 'This is a release candidate.'
     auth_token:
       secure: ij4UeXUYQBDJxn2YRAAhUOjklOGVKDB87Hn5J8tKIzj13yatoI7sLM666QDQFEgv
     artifact: Squirrel Installer, Portable Version, Squirrel nupkg, Squirrel RELEASES
-    draft: true
     force_update: true
     on:
       branch: master

   - provider: GitHub
      release: v$(flowVersion)
      auth_token:
         secure: ij4UeXUYQBDJxn2YRAAhUOjklOGVKDB87Hn5J8tKIzj13yatoI7sLM666QDQFEgv
      artifact: Squirrel Installer, Portable Version, Squirrel nupkg, Squirrel RELEASES
-    force_update: true
     on:
        APPVEYOR_REPO_TAG: true

[jjw24]

I am not sure what is defined as 'released' for the action without investigating.

How about we modify the appveyor deployment config so that commits to master create a RC release on the Prereleases repo, instead of a draft release on the main repo?

I dont think this is a necessary step.

If you have a look, whenever we merge to main, it runs two build process, once on merge and another on tag, and this takes a tremendous longer time to finish the whole release process. I want to see if it's possible to simplify, on merge -> build -> upload -> create release note draft (assuming this creates a tag as well). Hence I suggested maybe there is a step we can remove there which will also be able to help with WinGet action firing twice.

[jjw24]

I think this step is not necessary, we don't ever manually tag for release:

Flow.Launcher/appveyor.yml

Lines 79 to 86 in fa2c894

	- provider: GitHub
	release: v$(flowVersion)
	auth_token:
	secure: ij4UeXUYQBDJxn2YRAAhUOjklOGVKDB87Hn5J8tKIzj13yatoI7sLM666QDQFEgv
	artifact: Squirrel Installer, Portable Version, Squirrel nupkg, Squirrel RELEASES
	force_update: true
	on:
	APPVEYOR_REPO_TAG: true

[JohnTheGr8]

I think this step is not necessary, we don't ever manually tag for release:

Flow.Launcher/appveyor.yml

Lines 79 to 86 in fa2c894

	- provider: GitHub
	release: v$(flowVersion)
	auth_token:
	secure: ij4UeXUYQBDJxn2YRAAhUOjklOGVKDB87Hn5J8tKIzj13yatoI7sLM666QDQFEgv
	artifact: Squirrel Installer, Portable Version, Squirrel nupkg, Squirrel RELEASES
	force_update: true
	on:
	APPVEYOR_REPO_TAG: true

This deployment should also fire when you publish a release, if the associated tag does not already exist...

Maybe this explains why winget action runs twice: once when the draft release is manually promoted to published, and once more when AppVeyor finishes building that tag and force_updates the release. It isn't clear from their documentation, though...

Anyways, I think we can simplify the deployment setup by only creating a draft release on branch: master and APPVEYOR_REPO_TAG: false.

I think that would satisfy your requirements @jjw24 :

• the release is only published when manually promoted from draft, which should ensure the winget action fires only once.
• the tag build job does not affect the release process and therefore you don't need to wait for it to finish.

sounds good?

[jjw24]

the release is only published when manually promoted from draft, which should ensure the winget action fires only once.

Yes this would be the goal.

the tag build job does not affect the release process and therefore you don't need to wait for it to finish.

I suppose setting it to APPVEYOR_REPO_TAG: false makes sense if the previous steps do not create a tag, but if a tag is created when a draft release is created, I do not think this entire step is necessary. I do not know if this is the case that the tag is created before this step, so please test when working on this issue.