Installer: misleading error message on resources cleanup

[ppawlowski]

Current Behavior

When running the Device Agent installation via the Installer on a system, where a previous (or incomplete) Device Agent installation was detected, the installer shows a misleading error message:

[ERROR] No supported init system found or service not installed
No supported init system found or service was not installed on any system

Since the Installer accepts incomplete installations (no service configured in this case) and proceeds with removal of other resources, this message is misleading.

Source: #488 (comment)

Expected Behavior

Misleading messages should not be shown to the user.

Steps To Reproduce

1. Install the Device Agent using the Installer
2. Cancel installation with Ctrl + c
3. Start installation again and accept the removal of previous resources

Environment

• FlowFuse version:
• Node.js version:
• npm version:
• Platform/OS:
• Browser:

Linked Customers

• Customer name and/or link to HubSpot contact

[ppawlowski]

After reviewing current Installer's codebase, it seems like this issue has been fixed (unintentionally) in the latest release (1.2.0).
Currently, the installer catches potential errors from the service.Stop function, but doesn't show it to the user and continues execution.

				if err := service.Stop(perPortService); err != nil {
					logger.Debug("Failed to stop service %s: %v - continuing", perPortService, err)
				}

Due to the above, I am closing the issue.