Skip to content

Improve shutdown handling on Windows #79

@knolleary

Description

@knolleary

Description

Originally raised in FlowFuse/nr-launcher#111 (review)

When running on Windows, the localfs driver issues:

childProcess.exec(`taskkill /pid ${projectSettings.pid} /T /F`)

Which essentially kills the process without ever performing a clean shutdown (so non of this code is ever executed by the launcher)

A possible future "fix" (also perhaps an improvement?) might be to utilise ipc or pipe and use process.send to tell the launcher to "shutdown" before any kill operation. This would permit a chance to verify the "shutdown" actually occurs and an opportunity to grab logs entries on the shutdown process.

Epic/Story

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    taskA piece of work that isn't necessarily tied to a specific Epic or Story.

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions