test(mcp): authenticate equivalence smokes with the expert-mcp platform token

The instance-config smoke test minted a named personal access token, which
has its scope deleted at request time and therefore authenticates as the
full user, bypassing the user:expert-mcp allow-list check entirely. Switch
to the nameless expert-mcp platform token used in production so the
equivalence tests actually exercise the allow-list.

The directory used to seed the file-listing test is now created directly
through the container driver instead of the authenticated POST route,
since no instance-config tool creates files and that route is correctly
outside the expert-mcp token's allow-list.

Author: andypalmi

test/unit/forge/ee/lib/mcp/tools/instanceConfig_spec.js

@@ -1,7 +1,7 @@
 const should = require('should') // eslint-disable-line no-unused-vars
 const sinon = require('sinon')
 
-const { expectToolMatchesRoute } = require('../../../../../../lib/mcpToolEquivalence')
+const { expectToolMatchesRoute, createExpertMcpToken } = require('../../../../../../lib/mcpToolEquivalence')
 
 const FF_UTIL = require('flowforge-test-utils')
 
@@ -97,7 +97,7 @@ describe('MCP Tools: instanceConfig', function () {
     describe('integration tests', function () {
         const setup = require('../../../setup')
         let app
-        let pat
+        let token
         let configInstance
         let device
 
@@ -118,7 +118,7 @@ describe('MCP Tools: instanceConfig', function () {
                     }
                 }
             })
-            pat = await app.db.controllers.AccessToken.createPersonalAccessToken(app.user, '', null, 'smoke-pat')
+            token = await createExpertMcpToken(app)
 
             // customHostnames, protectedInstance and ha are enabled by default (team feature
             // defaults to true), but staticAssets and teamHttpSecurity default to false - turn
@@ -165,7 +165,7 @@ describe('MCP Tools: instanceConfig', function () {
                 ...options,
                 headers: {
                     ...(options.headers || {}),
-                    authorization: `Bearer ${pat.token}`
+                    authorization: `Bearer ${token}`
                 }
             })
         }
@@ -183,7 +183,7 @@ describe('MCP Tools: instanceConfig', function () {
             })
         })
 
-        // Each of these proves the tool hits the real route (same PAT-bearing inject) by
+        // Each of these proves the tool hits the real route (same expert-mcp-token-bearing inject) by
         // independently deriving {method, url} from the route registration, rather than
         // from the tool's own url-building code - see forge/ee/routes/index.js for the
         // mount prefixes and the individual forge/ee/routes/<feature>/index.js files for
@@ -246,12 +246,10 @@ describe('MCP Tools: instanceConfig', function () {
             })
 
             it('platform_list_instance_files matches GET /api/v1/projects/:instanceId/files/_/', async function () {
-                const createDir = await inject({
-                    method: 'POST',
-                    url: `/api/v1/projects/${configInstance.id}/files/_/`,
-                    payload: { path: 'uploads' }
-                })
-                createDir.statusCode.should.equal(200)
+                // Seed the directory directly through the container driver rather than the
+                // POST route: creating a file is not something any instance-config tool does,
+                // so it is deliberately outside the expert-mcp token's allow-list.
+                await app.containers.createDirectory(configInstance, '', 'uploads')
 
                 // The stub container driver stamps each listing entry with `new Date()` at
                 // call time, so freeze the clock while both the tool and the route are called