Skip to content

Decide the fate of the lost partial_cancel feature #534

Description

@Austinaminu2

File: contracts/streaming/src/lib.rs:265-271 (orphaned PartialCancelEvent struct), contracts/streaming/src/test_features.rs:437-608 (8 orphaned tests)
Problem: Commit 236b3ba ("#72 + #73 — Optimization and partial cancellation") added a partial_cancel() contract method. It was lost during the later merge-corruption repair (7fe0b2e), leaving behind: an orphaned PartialCancelEvent struct that's never published, and 8 tests in test_features.rs calling client.partial_cancel(...) against a method that no longer exists on StreamingContract.
Task: This needs a product/security judgment call, not a mechanical fix — touches vesting math and refund logic. Either (a) reimplement partial_cancel(), reconciling it with the current unlocked_amount-anchored top-up model that 7fe0b2e fixed, and make the 8 tests pass, or (b) formally remove the orphaned event struct and the 8 dead tests if the feature is out of scope. Document the decision in the PR description either way.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardThird CampaignCampaign: Third Campaignhelp wantedExtra attention is neededsecuritySecurity improvementssmart-contractSoroban smart contract

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions