Skip to content

Double encoded image urls when using SourceSetViewHelperTrait #1674

Open
@akiessling

Description

Related to #693, #1364

I have a FAL file with special chars as input for <v:media.image src="{image.id}" and srcset configuration.

When \FluidTYPO3\Vhs\Traits\SourceSetViewHelperTrait::addSourceSet runs, it already rawurlencodes the url when it calls static::preprocessSourceUri, then preprocessSourceUri runs rawurlencode again.

https://github.com/FluidTYPO3/vhs/blob/development/Classes/Traits/SourceSetViewHelperTrait.php#L52
https://github.com/FluidTYPO3/vhs/blob/development/Classes/ViewHelpers/Media/AbstractMediaViewHelper.php#L61

Result: "Lösungen" becomes "L%25C3%25B6sungen" instead of "L%C3%B6sungen".
I guess the encoding in addSourceSet should be dropped

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions