Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs - add separate usage example for activations() #1173

Open
obviousnic opened this issue May 11, 2020 · 0 comments
Open

docs - add separate usage example for activations() #1173

obviousnic opened this issue May 11, 2020 · 0 comments

Comments

@obviousnic
Copy link

obviousnic commented May 11, 2020

A minor issue in the docs for the activations() function in src/layers/basic.jl.

If a beginner following the previous examples in the docs, e.g.
loss(x, y) = crossentropy(m(x), y) + sum(norm, params(m))
and substituting activations() for params(), this will
result in the forward pass being computed twice, once when the model is evaluated, and again when activations is called.

The doc entry for activations() could provide an example or comment to emphasize that the model should not be called except through activations() itself.

@obviousnic obviousnic changed the title activations() computes the forward pass from scratch docs - add separate usage example for activations() May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants