Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

have buildkite run GPU tests only #2271

Closed
CarloLucibello opened this issue Jun 17, 2023 · 3 comments · Fixed by #2301
Closed

have buildkite run GPU tests only #2271

CarloLucibello opened this issue Jun 17, 2023 · 3 comments · Fixed by #2301
Labels
help wanted testing

Comments

@CarloLucibello
Copy link
Member

Currently buildkite is running both cpu and gpu tests.
Since cpu tests take quite some time and they run on the github CI already we should let buildkite run only the gpu tests.
@codetalker7
Copy link
Contributor

For this, how about: adding a new environment variable "FLUX_TEST_CPU", and run each CPU test block only if this variable is true?

@ToucheSir
Copy link
Member

Sounds reasonable to me, but it should be true by default to support running tests locally.

@codetalker7
Copy link
Contributor

Yes, sure.

@codetalker7 codetalker7 mentioned this issue Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run only GPU tests on buildkite. codetalker7/Flux.jl
4 participants
@ToucheSir @CarloLucibello @mcabbott @codetalker7