Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AMDGPU to 0.9 #2449

Merged
merged 3 commits into from
May 23, 2024
Merged

Bump AMDGPU to 0.9 #2449

merged 3 commits into from
May 23, 2024

Conversation

pxl-th
Copy link
Member

@pxl-th pxl-th commented May 20, 2024

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.98%. Comparing base (d39d13b) to head (f33c42b).

Current head f33c42b differs from pull request most recent head eac1fb0

Please upload reports for the commit eac1fb0 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2449       +/-   ##
===========================================
+ Coverage   46.10%   73.98%   +27.87%     
===========================================
  Files          32       32               
  Lines        1876     1922       +46     
===========================================
+ Hits          865     1422      +557     
+ Misses       1011      500      -511     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@darsnack darsnack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the patch?

@pxl-th
Copy link
Member Author

pxl-th commented May 20, 2024

Should be good to go now

@pxl-th
Copy link
Member Author

pxl-th commented May 21, 2024

@darsnack can you please merge it? I don't have write permissions

@darsnack
Copy link
Member

The GPU test failure seems real? Can you look into that?

@pxl-th
Copy link
Member Author

pxl-th commented May 21, 2024

That issue seems to come from LLVM and when having CUDA, AMDGPU and Metal in the same project.
Maybe we should add respective package only when testing for the selected GPU backend?

Although I was able to reproduce only Metal BFloat16 precompilation failure locally

@darsnack darsnack merged commit 2f19e68 into FluxML:master May 23, 2024
5 of 8 checks passed
@pxl-th pxl-th deleted the pxl-th/amdgpu branch June 4, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants