Conversation
This seems to be the source of the test fail with the error being That said, I believe I have only modified the docs folder so that should be completely orthogonal on this fail. |
ablaom
left a comment
ablaom
left a comment
There was a problem hiding this comment.
Looks great! Thanks for your patience with the review.
Co-authored-by: Anthony Blaom, PhD <anthony.blaom@gmail.com>
Co-authored-by: Essam <essamwisam@outlook.com>
|
Kindly do let me know if I need to take any action here before it's merged. |
|
@EssamWisam Can you please rebase to see if that fixes your buildkite (GPU) fail? It's possible this was fixed by #284 but I'm not sure. |
Rebase entity-tutorial
Yes, it works now. |
ablaom
left a comment
ablaom
left a comment
There was a problem hiding this comment.
Looks great. Appreciate this valuable enhancement to the docs.
2 participants
It dawned on me that entity embeddings is a noteworthy feature of this package and that it deserves a workflow example illustrating: (i), how it can be used and (ii), hints on how it works.
In particular, I was going to proceed with making an interface at MLJTransforms but felt I need to refresh my self on how this works first so I thought making this tutorial is a good way.