(Smaller PR) Adding support for Sin (#106)

* Adding support for Sin

* Added support and relevant test for Sin

* Sin testset

* Sin testset

* Sin test correction (v3)

* I swear I removed that last commit (v4)

* Update Project.toml

Author: dstarkenburg

src/load.jl

@@ -47,6 +47,9 @@ struct OpConfig{BE, Op} end
 const VarVec = Vector{Umlaut.Variable}
 const AttrDict = Dict{Symbol, Any}
 
+function load_node!(tape::Tape, ::OpConfig{:ONNX, :Sin}, args::VarVec, attrs::AttrDict)
+    return push_call!(tape, _sin, args[1])
+end
 
 function load_node!(tape::Tape, nd::NodeProto, backend::Symbol)
     args = [tape.c.name2var[name] for name in nd.input]
@@ -68,7 +71,6 @@ function load_node!(tape::Tape, nd::NodeProto, backend::Symbol)
     end
 end
 
-
 function load_node!(tape::Tape, ::OpConfig{:ONNX, :Gemm}, args::VarVec, attrs::AttrDict)
     if (length(args) == 2 && get(attrs, :alpha, 1) == 1 &&
         get(attrs, :transA, 0) == 0 && get(attrs, :transB, 0) == 0)

src/ops.jl

@@ -47,6 +47,7 @@ end
 
 add(xs...) = .+(xs...)
 sub(xs...) = .-(xs...)
+_sin(x) = sin.(x)
 mul(xs...) = .*(xs...)
 relu(x) = NNlib.relu.(x)
 leakyrelu(x;a = 0.01) = NNlib.leakyrelu.(x,a)

src/save.jl

@@ -111,6 +111,10 @@ function save_node!(g::GraphProto, ::OpConfig{:ONNX, typeof(getfield)}, op::Umla
     # Using getfield() for anything other then destructuring is thus a mistake.
 end
 
+function save_node!(g::GraphProto, ::OpConfig{:ONNX, typeof(_sin)}, op::Umlaut.Call)
+    nd = NodeProto("Sin", op)
+    push!(g.node, nd)
+end
 
 function save_node!(g::GraphProto, ::OpConfig{:ONNX, typeof(*)}, op::Umlaut.Call)
     nd = NodeProto(

test/saveload.jl

@@ -20,6 +20,11 @@ import ONNX: NodeProto, ValueInfoProto, AttributeProto, onnx_name
         ort_test(ONNX.mul, args...)
     end
 
+    @testset "Sin" begin
+        A = rand(3, 4)
+        ort_test(ONNX._sin, A)
+    end
+
     @testset "Gemm" begin
         A, B, C = (rand(3, 4), rand(3, 4), rand(3, 3))
         ort_test(ONNX.onnx_gemm, A, B')