Merge pull request #1462 from FluxML/bc/rm-boundscheck

Handle `Expr(:boundscheck)`

Author: ToucheSir

src/compiler/reverse.jl

@@ -132,6 +132,10 @@ function instrument(ir::IR)
     elseif isexpr(ex, :(=))
       @assert ex.args[1] isa GlobalRef
       pr[v] = xcall(Zygote, :global_set, QuoteNode(ex.args[1]), ex.args[2])
+    elseif isexpr(ex, :boundscheck)
+      # Expr(:boundscheck) now appears in common Julia code paths, so we need to handle it.
+      # For correctness sake, fix to true like https://github.com/dfdx/Umlaut.jl/issues/34.
+      pr[v] = true
     else
       ex = instrument_new!(pr, v, ex)
       ex = instrument_literals!(pr, v, ex)

test/compiler.jl

@@ -226,6 +226,15 @@ end
 # issue 897
 @test gradient(x -> sum(norm, collect(eachcol(x))), ones(3, 400))[1] ≈ fill(0.5773502691896258, 3, 400)
 
+# Tests adapted from https://github.com/dfdx/Umlaut.jl/pull/35
+@eval _has_boundscheck(x) = ifelse($(Expr(:boundscheck)), 2x, x)
+
+@testset "Meta Expr handling" begin
+  y, (dx,) = withgradient(_has_boundscheck, 1)
+  @test y == 2
+  @test dx == 2
+end
+
 # issue 1118 & 1380
 function f_1380(x)
     if rand(Bool)