Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test with ChainRulesTestUtils #1045

Open
CarloLucibello opened this issue Jul 28, 2021 · 2 comments
Open

test with ChainRulesTestUtils #1045

CarloLucibello opened this issue Jul 28, 2021 · 2 comments
Labels
ChainRules adjoint -> rrule, and further integration discussion

Comments

@CarloLucibello
Copy link
Member

we should replace out testing utilities
https://github.com/FluxML/Zygote.jl/blob/master/test/gradcheck.jl

with the ones given by ChainRulesTestUtils.
https://juliadiff.org/ChainRulesTestUtils.jl/dev/#Testing-AD-systems
@mcabbott
Copy link
Member

mcabbott commented Aug 1, 2021

Maybe. There's something to be said for keeping legacy tests as they were, so that you can be quite sure what's changed if they fail. And, if spending time re-writing things, perhaps it's better spend on transferring rules to ChainRules, & adding upgraded tests there.

@ToucheSir
Copy link
Member

Now that we are free of Zygote-isms in src/ and upstreamed as many rules as we can to ChainRules (in Flux, Zygote is still a WIP), perhaps it's time to revisit this.

@mcabbott mcabbott added discussion ChainRules adjoint -> rrule, and further integration labels Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ChainRules adjoint -> rrule, and further integration discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ToucheSir @CarloLucibello @mcabbott