Make webhook dead-letter transitions atomic with delivery attempts

[Jagadeeshftw]

Area: Webhooks / data integrity

Problem

Webhook store, retry, and DLQ paths update delivery status and attempts across failure boundaries.

Design decision required

Define the terminal state transition and whether an attempt and DLQ insertion share one transaction.

Deliverable

Inject DB/network failures at each boundary and assert no delivery is both active and dead-lettered.

Acceptance criteria

• The selected behavior is implemented and covered by focused regression tests.
• Failure, boundary, retry, and authorization behavior is explicit where applicable.
• Existing behavior outside this scope remains unchanged.
• CI output and any performance/resource impact are reported in the PR.

Out of scope

• Typo-only, documentation-only, unrelated refactors, and dependency churn.
• Closing, weakening, or skipping tests to make the change pass.

Verification

pnpm vitest run tests/webhooks/store.test.ts tests/dlq.test.ts

PR requirements

• Keep the PR focused, explain the before/after behavior, and reference this issue.
• Include the requested regression evidence and relevant CI results.
• Open the PR within 48 hours of assignment or leave a scope question on the issue.
• Contributor discussion: https://t.me/+u5qmu35nZ7I0OTU1

[TheShnider]

@TheShnider has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi. I have reviewed this issue and would like to work on it.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @TheShnider to this issue.

[Hey-Yetunde]

@Hey-Yetunde has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi i would like to work on this issue please assign to me
I can do it perfectly

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Hey-Yetunde to this issue.

[Peolite1]

@Peolite1 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

I would love to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Peolite1 to this issue.

[Zymogen45]

@Zymogen45 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi Ser! I'd love to work on this. I've gone through the description and I already know exactly what needs to be done. I'll deliver a clean, well-tested PR that meets every acceptance criterion. Can I get it assigned?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Zymogen45 to this issue.

[Kaycee276]

@Kaycee276 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi maintainer, can i work on this?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Kaycee276 to this issue.

[Jagadeeshftw]

@Gpraiz01, Good luck with this contribution—please keep the implementation focused and thoroughly validated.\n\nYou are assigned to #1285 — Make webhook dead-letter transitions atomic with delivery attempts. Please read the complete issue description carefully before starting and begin working on it. Address every requirement, acceptance criterion, and expected behavior mentioned there in your PR; ensure the PR covers the full issue scope and is a high-quality, reviewable contribution. Please validate the edge cases described in the issue before requesting review.\n\nPlease raise the PR within 48 hours of this assignment. If no PR is opened within 48 hours, you may be unassigned so the issue can be offered to another contributor.\n\nPlease also join our Telegram group: https://t.me/+u5qmu35nZ7I0OTU1

[drips-wave]

Congratulations, @Gpraiz01! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Gpraiz01: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊