fix: add pluralized translations for stream counts and batch results - #1592
Merged
Jagadeeshftw merged 7 commits intoAug 31, 2026
Conversation
|
@Cashman-Exchange Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds pluralized translation keys for stream counts and batch-result messages. It covers zero, one, and many forms for counts, successes, failures, and skipped records, and replaces hardcoded English count strings with locale-aware
t()lookups in the affected components.Related Issue
Changes
🌐 Pluralized Stream Counts
src/components/CreateStreamModal.tsxzero,one,many).src/components/RecentStreams.tsxt('streams.count', { count }).src/components/StreamTimeline.tsx🌐 Pluralized Batch Results
src/components/csv-upload/PreviewValidateStep.tsx{{count}}placeholders for stream counts and batch results.src/components/csv-upload/__tests__/PreviewValidateStep.test.tsx— asserts zero/one/many forms for batch result messages.src/components/__tests__/RecentStreams.test.tsx— asserts pluralized stream counts.src/components/__tests__/StreamTimeline.duration.test.tsx— asserts pluralized stream count/duration messages.Verification Results
zero/one/manykeys for stream counts and batch successes, failures, and skipped recordst()pluralized keys onlyCloses #1570