Lint the windows too: tools/lint_clang.ps1 checks src/ui and tests/ui

- The clang lint left src/ui and tests/ui out for want of Slint's headers, and 1.3.3 was lost to
  what that hid: a NUL byte inside a string literal in tests/ui, which MSVC accepts and GCC
  refuses. It takes Slint's headers and the generated components from the local preset's tree
  (build\windows-msvc) now, says to build that when it is missing, and checks everything CI
  compiles with -Werror: 197 files, about 15 minutes. Run against the 1.3.3 test file, it reports
  the NUL at the line GCC stopped on.
- Its first runs over the windows found five things only clang reports, all fixed: two
  GetProcAddress results cast to a function type they do not match (now through `void (*)()`), a
  volatile parameter (deprecated since C++20) in the stack-overflow crash helper, and two floats
  widened to double without saying so. The crash tests still see the stack overflow.

Author: Fohdeesha

src/ui/crash_report.cpp

@@ -262,8 +262,10 @@ void CrashReport::install(const std::filesystem::path& directory, std::string_vi
     // Looked up now, while the process is healthy: loading a DLL from inside a crash is how a
     // crash handler becomes a hang.
     if (const HMODULE dbghelp = LoadLibraryW(L"dbghelp.dll")) {
-        g_writeDump =
-            reinterpret_cast<MiniDumpWriteDumpFn>(GetProcAddress(dbghelp, "MiniDumpWriteDump"));
+        // Through `void (*)()`, the one function type any other is cast to and from without a
+        // compiler saying the two do not match: GetProcAddress hands back one that does not.
+        g_writeDump = reinterpret_cast<MiniDumpWriteDumpFn>(
+            reinterpret_cast<void (*)()>(GetProcAddress(dbghelp, "MiniDumpWriteDump")));
     }
 
     redirectStderr();
@@ -362,10 +364,11 @@ namespace {
 
 /// Deeper until the stack runs out. Each frame writes an array of its own and adds to what the
 /// next returns, so the optimiser can neither drop the frames nor turn the calls into a loop.
-int deeper(volatile int depth) {
+int deeper(int depth) {
+    volatile int here = depth; // a volatile parameter is deprecated since C++20; a local is not
     volatile char frame[1024];
-    frame[0] = static_cast<char>(depth);
-    return depth < 0 ? frame[0] : deeper(depth + 1) + frame[0];
+    frame[0] = static_cast<char>(here);
+    return here < 0 ? frame[0] : deeper(here + 1) + frame[0];
 }
 
 } // namespace

src/ui/native_window.cpp

@@ -274,8 +274,9 @@ LogicalExtent fitToScreen(LogicalExtent wanted) noexcept {
     UINT dpi = 0;
     if (const HMODULE shcore = LoadLibraryW(L"shcore.dll"); shcore != nullptr) {
         using GetDpiForMonitorFn = HRESULT(WINAPI*)(HMONITOR, int, UINT*, UINT*);
-        const auto getDpi =
-            reinterpret_cast<GetDpiForMonitorFn>(GetProcAddress(shcore, "GetDpiForMonitor"));
+        // Through `void (*)()`, as `CrashReport::install` casts what GetProcAddress returns.
+        const auto getDpi = reinterpret_cast<GetDpiForMonitorFn>(
+            reinterpret_cast<void (*)()>(GetProcAddress(shcore, "GetDpiForMonitor")));
         UINT x = 0;
         UINT y = 0;
         constexpr int kEffectiveDpi = 0; // MDT_EFFECTIVE_DPI

src/ui/rule_text.cpp

@@ -88,7 +88,7 @@ trigger::Value parseValue(std::string_view text) {
             return trigger::Value::ofInt(static_cast<std::int32_t>(*number));
         }
         // Clamped to what a float holds, which converting past is undefined behaviour (L5).
-        const double most = std::numeric_limits<float>::max();
+        const double most = static_cast<double>(std::numeric_limits<float>::max());
         return trigger::Value::ofFloat(static_cast<float>(std::clamp(*number, -most, most)));
     }
     return trigger::Value::ofText(trimmed);

src/ui/rules_controller.cpp

@@ -217,7 +217,8 @@ RulesController::RulesController(output::OutputRunner& runner,
     window_->on_rule_muted_changed(finishing([this](bool on) { setMuted(on); }));
     window_->on_rule_muted_at(finishing([this](int index, bool on) { setMutedAt(index, on); }));
     window_->on_fold_clicked(finishing([this](int which) { toggleFold(which); }));
-    window_->on_rule_rate_changed(finishing([this](float factor) { nudgeRate(factor); }));
+    window_->on_rule_rate_changed(
+        finishing([this](float factor) { nudgeRate(static_cast<double>(factor)); }));
     // The name commits on every keystroke, so there is never anything of its own to carry.
     window_->on_rule_renamed([this](const slint::SharedString& n) { rename(std::string(n)); });
     window_->on_rule_tested(finishing([this] { test(); }));

tools/lint_clang.ps1

@@ -17,10 +17,11 @@
 #   powershell -ExecutionPolicy Bypass -File tools/lint_clang.ps1
 #   powershell -ExecutionPolicy Bypass -File tools/lint_clang.ps1 src/core/control
 #
-# `src/core`, `src/cli` and `tests` by default — the engine, the console and their tests, which
-# CI compiles with -Werror. `src/ui` and `tests/ui` are left out, by name: they need Slint's
-# headers and the generated `main_window.h`, which this script does not reconstruct. full.yml
-# builds them on every push, with GCC as well since the linux-tsan job.
+# `src/core`, `src/cli`, `src/ui` and `tests` by default — everything CI compiles with -Werror.
+# **The windows too**: `src/ui` and `tests/ui` need Slint's headers and the generated
+# `main_window.h`, and take them from the `local` preset's tree (`build\windows-msvc`), so build
+# that first. They were left out until 2026-10-08, and 1.3.3 was lost to what that hid: a NUL
+# byte inside a string literal in tests/ui, which MSVC accepts and GCC refuses.
 #
 # **A file clang could not parse is not a clean file.** It stops at the first header it cannot
 # find and then says nothing — which this script used to count as clean, for four tests/ui
@@ -30,8 +31,8 @@
 # Exits 1 if clang reports anything, 3 if a file could not be checked, 0 only if every file
 # was checked and nothing was found.
 
-param([string[]]$Paths = @('src/core', 'src/cli', 'tests'))
-$Exclude = @('src\ui\', 'tests\ui\')
+param([string[]]$Paths = @('src/core', 'src/cli', 'src/ui', 'tests'))
+$Exclude = @()
 
 # NOT 'Stop': Windows PowerShell wraps a native command's stderr in ErrorRecords, and
 # clang-tidy writes its "N warnings generated" summary there — which under 'Stop' aborts
@@ -48,6 +49,9 @@ if (-not (Test-Path "$build\generated")) {
     Write-Error "configure the local-core preset first: no $build\generated"
     exit 2
 }
+# The windows' Slint headers and generated components, from the `local` preset's tree.
+$app = Join-Path $repo 'build\windows-msvc'
+$appBuilt = Test-Path "$app\src\ui\main_window.h"
 
 # The include roots and defines takt4_tests is compiled with, from src/CMakeLists.txt and
 # tests/CMakeLists.txt. Kept by hand; if a target grows a dependency, add it here.
@@ -67,6 +71,9 @@ $flags = @(
     "-isystem$build\_deps\pugixml-src\src",
     "-isystem$build\_deps\miniz-src",
     '-DPUGIXML_NO_XPATH', '-DMINIZ_NO_STDIO', '-DMINIZ_NO_TIME', '-DMINIZ_NO_ZLIB_COMPATIBLE_NAMES',
+    "-I$app\src\ui",
+    "-isystem$app\_deps\slint-src\api\cpp\include",
+    "-isystem$app\_deps\slint-build\generated_include",
     "-isystem$repo\third_party\portaudio\include",
     "-isystem$repo\third_party\link\include",
     "-isystem$repo\third_party\link\modules\asio-standalone\asio\include",
@@ -150,6 +157,9 @@ if ($skipped.Count -gt 0) {
 if ($unchecked.Count -gt 0) {
     Write-Output "`n$($unchecked.Count) file(s) not checked - a header clang could not find, which is this script's include list, not the code:"
     $unchecked | ForEach-Object { Write-Output "  $_" }
+    if (-not $appBuilt) {
+        Write-Output "  (src/ui and tests/ui take Slint's headers from build\windows-msvc: build the local preset)"
+    }
 }
 if ($found -gt 0) { Write-Output "`n$found file(s) with findings"; exit 1 }
 if ($unchecked.Count -gt 0) { Write-Output "`nnothing found in the files that were checked, but not every file was"; exit 3 }