refactor: linting

Author: gidonkatten

eslint.config.js

@@ -45,8 +45,9 @@ export default tseslint.config(
       "@typescript-eslint/array-type": ["error", { default: "generic" }],
       "@typescript-eslint/consistent-type-definitions": ["error", "type"],
       "@typescript-eslint/consistent-type-imports": ["error", { prefer: "type-imports" }],
+      "@typescript-eslint/no-unnecessary-condition": "off",
       "@typescript-eslint/restrict-template-expressions": ["error", { allowNumber: true }],
-      "@typescript-eslint/switch-exhaustiveness-check": "error",
+      "@typescript-eslint/switch-exhaustiveness-check": "off",
       "unicorn/better-regex": "error",
       "unicorn/consistent-function-scoping": "error",
       "unicorn/expiring-todo-comments": "error",

examples/borrow.ts

@@ -58,7 +58,6 @@ async function main() {
   const isStableRate = false;
 
   let maxStableRate;
-  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   if (isStableRate) {
     const poolInfo = await FolksPool.read.poolInfo(tokenId);
     const interestRate = poolInfo.stableBorrowData.interestRate[0];

package.json

@@ -49,19 +49,20 @@
     "@commitlint/cz-commitlint": "^19.8.1",
     "@eslint/js": "^9.39.4",
     "@types/node": "^20.19.37",
-    "@typescript-eslint/parser": "^7.18.0",
+    "@typescript-eslint/eslint-plugin": "^8.57.1",
+    "@typescript-eslint/parser": "^8.57.1",
     "commitizen": "^4.3.1",
     "eslint": "^9.39.4",
     "eslint-config-prettier": "^9.1.2",
     "eslint-import-resolver-typescript": "^3.10.1",
     "eslint-plugin-import-x": "^0.5.3",
-    "eslint-plugin-unicorn": "^53.0.0",
+    "eslint-plugin-unicorn": "^63.0.0",
     "globals": "^15.15.0",
     "husky": "^9.1.7",
     "lint-staged": "^15.5.2",
     "prettier": "^3.8.1",
     "typescript": "^5.9.3",
-    "typescript-eslint": "^7.18.0"
+    "typescript-eslint": "^8.57.1"
   },
   "config": {
     "commitizen": {

pnpm-lock.yaml

@@ -58,7 +58,7 @@ export async function sendERC20Approve(
 
   // approve if not enough
   if (allowance < amount)
-    return await erc20.write.approve([spender, BigInt(amount)], {
+    return await erc20.write.approve([spender, amount], {
       account: getEvmSignerAccount(signer),
       chain: signer.chain,
     });

src/chains/evm/common/utils/contract.ts

@@ -23,7 +23,7 @@ export async function getAccountInfo(
   const accountManager = getAccountManagerContract(provider, hubChain.accountManagerAddress);
 
   // get chain ids to check
-  folksChainIds = folksChainIds ? folksChainIds : getFolksChainIdsByNetwork(network);
+  folksChainIds = folksChainIds ?? getFolksChainIdsByNetwork(network);
 
   // define return variable
   const accountInfo: AccountInfo = {
@@ -74,7 +74,7 @@ export async function getAccountIdByAddress(
   const accountManager = getAccountManagerContract(provider, hubChain.accountManagerAddress);
 
   // get chain ids to check
-  folksChainIds = folksChainIds ? folksChainIds : getFolksChainIdsByNetwork(network);
+  folksChainIds = folksChainIds ?? getFolksChainIdsByNetwork(network);
 
   const accountIds = await multicall(provider, {
     contracts: folksChainIds.map((folksChainId) => ({

src/chains/evm/hub/modules/folks-hub-account.ts

@@ -296,20 +296,20 @@ export async function getLoanTypeInfo(
       isDeprecated,
       reward: {
         minimumAmount,
-        collateralSpeed: [BigInt(collateralSpeed), 18],
-        borrowSpeed: [BigInt(borrowSpeed), 18],
+        collateralSpeed: [collateralSpeed, 18],
+        borrowSpeed: [borrowSpeed, 18],
         collateralRewardIndex: calcRewardIndex(
           collateralUsed,
           minimumAmount,
-          [BigInt(oldCollateralRewardIndex), 18],
-          [BigInt(collateralSpeed), 18],
+          [oldCollateralRewardIndex, 18],
+          [collateralSpeed, 18],
           lastUpdateTimestamp,
         ),
         borrowRewardIndex: calcRewardIndex(
           borrowUsed,
           minimumAmount,
-          [BigInt(oldBorrowRewardIndex), 18],
-          [BigInt(borrowSpeed), 18],
+          [oldBorrowRewardIndex, 18],
+          [borrowSpeed, 18],
           lastUpdateTimestamp,
         ),
       },
@@ -319,7 +319,7 @@ export async function getLoanTypeInfo(
   return {
     loanTypeId,
     deprecated,
-    loanTargetHealth: [BigInt(loanTargetHealth), 4],
+    loanTargetHealth: [loanTargetHealth, 4],
     pools,
   };
 }

src/chains/evm/hub/modules/folks-hub-loan.ts

@@ -199,9 +199,9 @@ export async function getPoolInfo(
       averageInterestYield: compoundEverySecond([stableBorrowAverageInterestRate, 18]),
     },
     capsData: {
-      deposit: BigInt(depositCap),
-      borrow: BigInt(borrowCap),
-      stableBorrowPercentage: [BigInt(stableBorrowPercentageCap), 18],
+      deposit: depositCap,
+      borrow: borrowCap,
+      stableBorrowPercentage: [stableBorrowPercentageCap, 18],
     },
     configData: {
       deprecated,

src/chains/evm/hub/modules/folks-hub-pool.ts

@@ -733,7 +733,7 @@ export const read = {
     return {
       periodLength: BigInt(periodLength),
       periodOffset: BigInt(periodOffset),
-      periodLimit: BigInt(periodLimit),
+      periodLimit,
       currentCapacity,
       nextPeriodReset,
     };

src/chains/evm/spoke/modules/folks-evm-loan.ts

@@ -343,9 +343,11 @@ export const util = {
 
     // check adapter id is supported
     const spokeTokenData = sendFolksTokenId ? getSpokeTokenData(spokeChain, sendFolksTokenId) : undefined;
-    spokeTokenData && sendFolksTokenId && isCrossChainToken(sendFolksTokenId)
-      ? assertAdapterSupportsCrossChainToken(fromFolksChainId, spokeTokenData.token as CrossChainTokenType, adapterId)
-      : assertAdapterSupportsDataMessage(fromFolksChainId, adapterId);
+    if (spokeTokenData && sendFolksTokenId && isCrossChainToken(sendFolksTokenId)) {
+      assertAdapterSupportsCrossChainToken(fromFolksChainId, spokeTokenData.token as CrossChainTokenType, adapterId);
+    } else {
+      assertAdapterSupportsDataMessage(fromFolksChainId, adapterId);
+    }
 
     return FolksEvmGmp.getSendMessageFee(
       FolksCore.getProvider<ChainType.EVM>(fromFolksChainId),
@@ -375,9 +377,11 @@ export const util = {
     if (!isRewards) {
       if (receiveFolksTokenId === undefined) throw Error("Unspecified receiveFolksTokenId");
       hubTokenData = getHubTokenData(receiveFolksTokenId, network);
-      isCrossChainToken(receiveFolksTokenId)
-        ? assertAdapterSupportsCrossChainToken(toFolksChainId, hubTokenData.token as CrossChainTokenType, adapterId)
-        : assertAdapterSupportsDataMessage(toFolksChainId, adapterId);
+      if (isCrossChainToken(receiveFolksTokenId)) {
+        assertAdapterSupportsCrossChainToken(toFolksChainId, hubTokenData.token as CrossChainTokenType, adapterId);
+      } else {
+        assertAdapterSupportsDataMessage(toFolksChainId, adapterId);
+      }
     } else {
       assertAdapterSupportsDataMessage(toFolksChainId, adapterId);
     }