refactor(tx_client): remove unnecessary type conversions for PFB gas limit (celestiaorg#5878)

Galoretka · web-flow · commit a68ce3a5acc4 · 2025-09-29T13:46:20.000Z
Replace the redundant float round-trip in PFB gas limit calculation by
using the uint64 returned from blobtypes.DefaultEstimateGas directly.
This removes unnecessary conversions, aligns with usage across the
codebase, and avoids any theoretical precision risk without changing
behavior.
diff --git a/pkg/user/tx_client.go b/pkg/user/tx_client.go
@@ -299,7 +299,7 @@ func (client *TxClient) BroadcastPayForBlobWithAccount(ctx context.Context, acco
 	if err != nil {
 		return nil, err
 	}
-	gasLimit := uint64(float64(blobtypes.DefaultEstimateGas(msg)))
+	gasLimit := blobtypes.DefaultEstimateGas(msg)
 	fee := uint64(math.Ceil(appconsts.DefaultMinGasPrice * float64(gasLimit)))
 	// prepend calculated params, so it can be overwritten in case the user has specified it.
 	opts = append([]TxOption{SetGasLimit(gasLimit), SetFee(fee)}, opts...)

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ func (client *TxClient) BroadcastPayForBlobWithAccount(ctx context.Context, acco`
`299`	`299`	`if err != nil {`
`300`	`300`	`return nil, err`
`301`	`301`	`}`
`302`		`- gasLimit := uint64(float64(blobtypes.DefaultEstimateGas(msg)))`
	`302`	`+ gasLimit := blobtypes.DefaultEstimateGas(msg)`
`303`	`303`	`fee := uint64(math.Ceil(appconsts.DefaultMinGasPrice * float64(gasLimit)))`
`304`	`304`	`// prepend calculated params, so it can be overwritten in case the user has specified it.`
`305`	`305`	`opts = append([]TxOption{SetGasLimit(gasLimit), SetFee(fee)}, opts...)`